#1780 - Associate MSFAA with disbursement #1847
Conversation
dheepak-aot
added
SIMS-Api
dheepak-aot
requested review from
andrewsignori-aot,
guru-aot,
andrepestana-aot,
ann-aot,
sh16011993 and
JasonCTang
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Outdated
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Outdated
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/workers/src/controllers/disbursement/disbursement.controller.ts
Show resolved
Hide resolved
sources/packages/backend/apps/workers/src/controllers/disbursement/disbursement.controller.ts
Outdated
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Outdated
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Outdated
Show resolved
Hide resolved
...ges/backend/apps/workers/src/services/disbursement-schedule/disbursement-schedule.service.ts
Outdated
Show resolved
Hide resolved
| completedStatus: ApplicationStatus.Completed, | ||
| }) | ||
| .andWhere("assessment.triggerType = :triggerType", { | ||
| triggerType: AssessmentTriggerType.OriginalAssessment, |
There was a problem hiding this comment.
I believe that we need to mention/explain/validate this change to @JasonCTang that we are no longer relying on the original assessment offering data to check MSFAA validity.
For instance, with the change, a reassessment of an application that was reusing an existing MSFAA, may en up creating a new MSFAA if the offering start date changes.
Assuming that the application's original assessment had the offering start date of Jan 1st, 2023 and it had an MSFAA valid till Jan 15th, 2023.
If the application is reassessed and the offering change to Jan 31st, 2023, a new MSFAA will be required, right?
I believe that this is the right change, we just need to ensure that it is captured in the ticket and that Jason is aware.
| if (!firstDisbursement) { | ||
| throw new CustomNamedError( | ||
| "Disbursement not found.", | ||
| DISBURSEMENT_NOT_FOUND, |
There was a problem hiding this comment.
Just for my understanding: if the disbursement is not found here, it will try to associate again in the next scheduled time, right? How many times the queue tries to associate it?
There was a problem hiding this comment.
Associate disbursement here is the state of workflow which happens after disbursements are saved for an assessment.
So the expectation at this state is there must be disbursement(s) available for the assessment to make the association happen.
There must never be a situation when trying to associate msfaa, the disbursements are not found unless there is hidden bug in workflow(for e.g. Save disbursement having an error but not failing and moving to next stage).
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Associate MSFAA with disbursement
Associate MSFAA with disbursement
Migration created to remove
msfaa_number_idfrom sims.applications and add to sims.disbursement_schedulesMoved the worker
associate-msfaatoDisbursementControllerfromApplicationControllerin workers as the associate msfaa is related to the disbursement now.E2E test for disbursement controller in worker is adjusted accordingly.
Assessment gateway workflow modified to have the service task to associate msfaa for both original assessment and re-assessments.
E2E test for assessment-gateway workflow is adjusted accordingly.
As DisbursementScheduleService is already available in shared library and it has not been named as *sharedService, the import is using
DisbursementScheduleService as DisbursementScheduleSharedServiceas we have one more DisbursementScheduleService at worker scope. Modifying DisbursementScheduleService to DisbursementScheduleSharedService is not considered to scope of PR or story.The MSFAA number is now at disbursement level, but the NOA still has only one placeholder for MSFAA(not at disbursement schedule level). Hence to get the value appearing in NOA correctly, it uses the msfaa of the first disbursement.
