Skip to content

Fix small typo and obsolete expressions. #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayconrod merged 2 commits into from
Apr 27, 2020
Merged

Fix small typo and obsolete expressions. #2459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e210a
Fix small typo and obsolete expressions.
ymotongpoo Apr 26, 2020
39c8987
Remove extra trailing space to render the table properly.
ymotongpoo Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go/toolchains.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Registering a custom SDK
~~~~~~~~~~~~~~~~~~~~~~~~

If you download the SDK through another repository rule, you can configure
it with ``go_wrap_sdk``. It must still be named ``go_sdk``, but this is a
it with ``go_wrap_sdk``. It must still be named ``go_sdk``, but this is a
temporary limitation that will be removed in the future.

.. code:: bzl
Expand Down Expand Up @@ -268,7 +268,7 @@ This downloads a Go SDK for use in toolchains.
| supports. Go versions that rules_go doesn't support may not be specified, |
| since the download SHA-256 sums are not known. |
+--------------------------------+-----------------------------+---------------------------------------------+
| :param:`urls` | :type:`string_list` | :value:`[https://dl.google.com/go/{}` |
| :param:`urls` | :type:`string_list` | :value:`[https://dl.google.com/go/{}]` |
+--------------------------------+-----------------------------+---------------------------------------------+
| A list of mirror urls to the binary distribution of a Go SDK. These must contain the `{}` |
| used to substitute the sdk filename being fetched (using `.format`. |
Expand Down Expand Up @@ -467,7 +467,7 @@ The context object
~~~~~~~~~~~~~~~~~~

``GoContext`` is never returned by a rule, instead you build one using
``go_context(ctx)`` in the top of any custom skylark rule that wants to interact
``go_context(ctx)`` in the top of any custom starlark rule that wants to interact
with the go rules. It provides all the information needed to create go actions,
and create or interact with the other go providers.

Expand Down