Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Red Hat UBI base image for imps-refresher image #32

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add Red Hat UBI base image for imps-refresher image #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Check dependency licenses
env:
GITHUB_TOKEN: ${{ github.token }} # Note: this is required for licensei auth in steps to avoid rate-limiting.
run: make license-check
run: go mod vendor && make license-check
Copy link
Author

@vhosakot vhosakot Apr 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendoring in deps in CI before checking their licenses per banzaicloud/koperator#853 (comment) to resolve spurious license errors in CI when contacting github.com, thanks to @panyuenlau for this tip.


- name: Run lint
run: GOLANGCI_VERSION=${{ env.GOLANGCI_LINT_VERSION }} make lint
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/docker_refresher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,15 @@ jobs:
cache-to: type=local,dest=/tmp/.buildx-cache
tags: |
ghcr.io/banzaicloud/imagepullsecrets-refresher:${{ steps.imagetag.outputs.value }}
- name: Build imagepullsecrets refresher with Red Hat UBI base image
uses: docker/build-push-action@v3
with:
file: Dockerfile-refresher
platforms: ${{ env.PLATFORMS }}
push: true
cache-from: type=local,src=/tmp/.buildx-cache
cache-to: type=local,dest=/tmp/.buildx-cache
build-args: |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs about build-args: in GitHub action for docker build:

FROM_IMAGE=redhat/ubi8-micro
tags: |
ghcr.io/banzaicloud/imagepullsecrets-refresher-rh-ubi8:${{ steps.imagetag.outputs.value }}
1 change: 1 addition & 0 deletions Dockerfile-refresher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ WORKDIR /
COPY --from=builder /etc/nsswitch.conf.build /etc/nsswitch.conf
COPY --from=builder /usr/share/zoneinfo /usr/share/zoneinfo
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
COPY --from=builder /workspace/LICENSE.md /licenses/LICENSE.md

COPY --from=builder /workspace/manager .
USER nobody:nobody
Expand Down