Build args

[shyam-ks]

I am trying to setup docker build in Github actions

- name: build-1
        run: |
          docker build . --build-arg JFROG_USERNAME=${{ secrets.JFROG_CREDS_USR }} --build-arg JFROG_PWD=${{ secrets.JFROG_CREDS_PSW }} 

      - name: build-2
        uses: docker/build-push-action@v2
        with:
          context: .
          file: ./Dockerfile
          push: false
          build-args: JFROG_USERNAME=${{ secrets.JFROG_CREDS_USR }},JFROG_PWD=${{ secrets.JFROG_CREDS_PSW }}

I have two args inside Dockerfile

ARG JFROG_PWD
ARG JFROG_USERNAME

Behaviour

In Dockerfile the command is = value="${JFROG_USERNAME}"

The first one (build-1) builds successfully, the Second one fails because the whole build args value is going to a single variable. like below
value=",JFROG_PWD="

Expected behavior - value="***"

I'm not able to figure out why the 2 build args are not setting values to their respective args inside Dockerfile when I am using docker/build-push-action@v2

[makoncline]

I think you should write it like this.

build-args: |
    JFROG_USERNAME=${{ secrets.JFROG_CREDS_USR }}
    JFROG_PWD=${{ secrets.JFROG_CREDS_PSW }}

[shyam-ks]

I think you should write it like this.

build-args: |
    JFROG_USERNAME=${{ secrets.JFROG_CREDS_USR }}
    JFROG_PWD=${{ secrets.JFROG_CREDS_PSW }}

That worked. Thanks

[ckingbailey]

Would be nice if this was documented. There are no examples at the examples link, and the documentation says it's a "List", which I interpreted to mean a YAML list, like

build-args:
  - foo=bar
  - baz=yaz

or

build-args: [ 'foo=bar', 'baz=yaz' ]

which GitHub Actions language server in VSCode tells me is not valid input. (I'm guessing only strings, numbers, and booleans are valid arguments to an action? You learn something new...)

For reference, an example of an action that does document list-like syntax like this is actions/upload-artifact.

[aharpervc]

Would be nice if this was documented

I agree, I just found this discussion by searching for build args, since the readme offered no clarity and I assumed someone else had already complained 😁

[ibrahima]

Ah, I was going to submit a PR for an example, but I realized it is actually documented at the top of the parameters section: https://github.com/docker/build-push-action#customizing

[besmirzanaj]

Ah, I was going to submit a PR for an example, but I realized it is actually documented at the top of the parameters section: https://github.com/docker/build-push-action#customizing

again this is not a YAML list, so the definition of the doc should be changed/updated

[xinatcg]

Would be nice if this was documented. There are no examples at the examples link, and the documentation says it's a "List", which I interpreted to mean a YAML list, like

build-args:
  - foo=bar
  - baz=yaz

or

build-args: [ 'foo=bar', 'baz=yaz' ]

which GitHub Actions language server in VSCode tells me is not valid input. (I'm guessing only strings, numbers, and booleans are valid arguments to an action? You learn something new...)

For reference, an example of an action that does document list-like syntax like this is actions/upload-artifact.

Hope there example can be in the doc, it is easy to make mistake