-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Red Hat UBI base image for imps-refresher image #32
Conversation
push: true | ||
cache-from: type=local,src=/tmp/.buildx-cache | ||
cache-to: type=local,dest=/tmp/.buildx-cache | ||
build-args: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs about build-args:
in GitHub action for docker build:
- Build args docker/build-push-action#557 (comment)
- https://github.com/docker/build-push-action#inputs
-
build-args
| List | List of build-time variables
-
CI licensei error: might need to use v0.8.0 of licensei-- https://github.com/goph/licensei/releases/tag/v0.8.0 currently, the Makefile is using 0.7.0 |
Signed-off-by: Vikram Hosakote <[email protected]>
fc89b50
@@ -67,7 +67,7 @@ jobs: | |||
- name: Check dependency licenses | |||
env: | |||
GITHUB_TOKEN: ${{ github.token }} # Note: this is required for licensei auth in steps to avoid rate-limiting. | |||
run: make license-check | |||
run: go mod vendor && make license-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendoring in deps in CI before checking their licenses per banzaicloud/koperator#853 (comment) to resolve spurious license errors in CI when contacting github.com, thanks to @panyuenlau for this tip.
thanks, vendoring in the deps fixed the error in CI, more info is in #32 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's in this PR?
imagepullsecrets-refresher
container is installed by thesmm-operator
helm chart and Red Hat certification of Cisco's Calisti1.12
on OpenShift requires all images installed by thesmm-operator
helm chart to have Red Hat UBI (Universal Base Image) as the base image and the/licenses
directory. So, adding them forimagepullsecrets-refresher
image and updated.github/workflows/docker_refresher.yml
to build a newimagepullsecrets-refresher
image with UBI base image.Why?
Needed for Red Hat certification of Cisco's Calisti
1.12
on OpenShift.Additional context
Checklist
Test results: