Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating docs #458

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: Updating docs #458

merged 1 commit into from
Dec 21, 2023

Conversation

ayonious
Copy link
Owner

@ayonious ayonious commented Dec 21, 2023

👀What is this pr about?

Fixes on docs based on this
Based on this: #456

🚀 Changes

Added

  • feature1
  • feature2

Fixed

Updated

🖼 Screenshots

Before After
🧟 😎

👶 The naming of the PR

chore(deps): some dependency update
feat: Line Width is not limited, previously it was unlimited
fix(technical): Deployment issue with npm is fixed
fix: title names can be decorated

@ayonious ayonious merged commit 15ce90a into master Dec 21, 2023
1 check failed
@ayonious ayonious deleted the update-docs branch December 21, 2023 14:38
ayonious pushed a commit that referenced this pull request Dec 22, 2023
# [2.12.0](v2.11.2...v2.12.0) (2023-12-22)

### Bug Fixes

* Multiple line Title ([#453](#453)) ([4876a92](4876a92))
* Updating docs to include better examples ([#458](#458)) ([15ce90a](15ce90a))

### Features

* Allow for color: false to wipe the colorMap. ([#455](#455)) ([9405d83](9405d83))
@ayonious
Copy link
Owner Author

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Comment on lines -40 to +41
{ index: 3, text: 'I would like some gelb bananen bitte', value: 100 },
{ index: 4, text: 'I hope batch update is working', value: 300 },
{ Rank: 3, text: 'I would like some Yellow', value: 100 },
{ Rank: 4, text: 'I hope batch update is working', value: 300 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to suggest changing Rank to rank because most keys I see in JavaScript start with lowercase. Thanks.

Copy link
Owner Author

@ayonious ayonious Dec 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I was about to create another PR for making this change. But then thought maybes its better because, having also some uppercase in dataset makes it look like "keys"/"Column Names" don't need to start with lowercase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having also some uppercase in dataset makes it look like "keys"/"Column Names" don't need to start with lowercase

IMHO, given javascript syntax, I think that's already implied.

Comment on lines +40 to +41
{ Rank: 3, text: 'I would like some Yellow', value: 100 },
{ Rank: 4, text: 'I hope batch update is working', value: 300 },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ Rank: 3, text: 'I would like some Yellow', value: 100 },
{ Rank: 4, text: 'I hope batch update is working', value: 300 },
{ rank: 3, text: 'I would like some Yellow', value: 100 },
{ rank: 4, text: 'I hope batch update is working', value: 300 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants