-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating docs #458
fix: Updating docs #458
Conversation
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
{ index: 3, text: 'I would like some gelb bananen bitte', value: 100 }, | ||
{ index: 4, text: 'I hope batch update is working', value: 300 }, | ||
{ Rank: 3, text: 'I would like some Yellow', value: 100 }, | ||
{ Rank: 4, text: 'I hope batch update is working', value: 300 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to suggest changing Rank
to rank
because most keys I see in JavaScript start with lowercase. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I was about to create another PR for making this change. But then thought maybes its better because, having also some uppercase in dataset makes it look like "keys"/"Column Names" don't need to start with lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having also some uppercase in dataset makes it look like "keys"/"Column Names" don't need to start with lowercase
IMHO, given javascript syntax, I think that's already implied.
{ Rank: 3, text: 'I would like some Yellow', value: 100 }, | ||
{ Rank: 4, text: 'I hope batch update is working', value: 300 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ Rank: 3, text: 'I would like some Yellow', value: 100 }, | |
{ Rank: 4, text: 'I hope batch update is working', value: 300 }, | |
{ rank: 3, text: 'I would like some Yellow', value: 100 }, | |
{ rank: 4, text: 'I hope batch update is working', value: 300 } |
👀What is this pr about?
Fixes on docs based on this
Based on this: #456
🚀 Changes
Added
Fixed
Updated
🖼 Screenshots
👶 The naming of the PR
chore(deps): some dependency update
feat: Line Width is not limited, previously it was unlimited
fix(technical): Deployment issue with npm is fixed
fix: title names can be decorated