feat(modal): update docker tag to use torch2.6 from torch2.5#2749
Conversation
WalkthroughThe change updates the default Docker image tag used in the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/axolotl/cli/cloud/modal_.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: PyTest from Source Dist (3.11, 2.7.0)
- GitHub Check: PyTest (3.11, 2.6.0)
- GitHub Check: PyTest from Source Dist (3.11, 2.5.1)
- GitHub Check: PyTest (3.11, 2.7.0)
- GitHub Check: PyTest (3.11, 2.5.1)
- GitHub Check: PyTest from Source Dist (3.11, 2.6.0)
|
|
||
| def get_image(self): | ||
| docker_tag = "main-py3.11-cu124-2.5.1" | ||
| docker_tag = "main-py3.11-cu124-2.6.0" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify the new Docker tag and remove stale references.
The default image tag has been bumped from "main-py3.11-cu124-2.5.1" to "main-py3.11-cu124-2.6.0". Please ensure that:
- The new image is published on Docker Hub and pullable.
- No lingering references to the old tag remain in documentation/configuration.
Run this script to confirm:
🏁 Script executed:
#!/bin/bash
# 1. Check for leftover old tag references in the repo
rg -n "main-py3.11-cu124-2\.5\.1"
# 2. Verify the new tag manifest exists on Docker Hub
docker manifest inspect axolotlai/axolotl:main-py3.11-cu124-2.6.0Length of output: 247
🏁 Script executed:
#!/bin/bash
# Verify no leftover old tag references
rg -n "main-py3.11-cu124-2\.5\.1"
# Check the new tag exists on Docker Hub via Registry HTTP API
curl -sSL -o /dev/null -w "HTTP status for new tag: %{http_code}\n" \
"https://registry.hub.docker.com/v2/repositories/axolotlai/axolotl/tags/main-py3.11-cu124-2.6.0"Length of output: 276
Remove stale Docker tag reference in documentation
Verified that the new Docker tag (main-py3.11-cu124-2.6.0) exists on Docker Hub (HTTP 200). However, there’s still a reference to the old tag in the docs:
• docs/docker.qmd:78
Please update it as follows:
- `main-py3.11-cu124-2.5.1`
+ `main-py3.11-cu124-2.6.0`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| docker_tag = "main-py3.11-cu124-2.6.0" | |
| --- a/docs/docker.qmd | |
| +++ b/docs/docker.qmd | |
| @@ -75,7 +75,7 @@ | |
| <!-- (other content above) --> | |
| -`main-py3.11-cu124-2.5.1` | |
| +`main-py3.11-cu124-2.6.0` | |
| <!-- (other content below) --> |
🤖 Prompt for AI Agents
In src/axolotl/cli/cloud/modal_.py at line 85, update the docker_tag variable to
"main-py3.11-cu124-2.6.0" as already done. Then, search the entire repository
for any remaining references to the old tag "main-py3.11-cu124-2.5.1" and
replace them with the new tag. Specifically, update the reference in
docs/docker.qmd at line 78 to use the new tag "main-py3.11-cu124-2.6.0" to
ensure consistency and remove stale references.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
2 participants
Description
We now recommend torch2.6, so let's update modal's default tag too.
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Summary by CodeRabbit