Skip to content

feat(modal): update docker tag to use torch2.6 from torch2.5 #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NanoCode012 merged 1 commit into from
Jun 3, 2025
Merged

feat(modal): update docker tag to use torch2.6 from torch2.5 #2749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/axolotl/cli/cloud/modal_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def get_env(self):
return res

def get_image(self):
docker_tag = "main-py3.11-cu124-2.5.1"
docker_tag = "main-py3.11-cu124-2.6.0"

@coderabbitai coderabbitai Bot Jun 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify the new Docker tag and remove stale references.

The default image tag has been bumped from "main-py3.11-cu124-2.5.1" to "main-py3.11-cu124-2.6.0". Please ensure that:

  1. The new image is published on Docker Hub and pullable.
  2. No lingering references to the old tag remain in documentation/configuration.

Run this script to confirm:

🏁 Script executed:

#!/bin/bash
# 1. Check for leftover old tag references in the repo
rg -n "main-py3.11-cu124-2\.5\.1"

# 2. Verify the new tag manifest exists on Docker Hub
docker manifest inspect axolotlai/axolotl:main-py3.11-cu124-2.6.0

Length of output: 247

🏁 Script executed:

#!/bin/bash
# Verify no leftover old tag references
rg -n "main-py3.11-cu124-2\.5\.1"

# Check the new tag exists on Docker Hub via Registry HTTP API
curl -sSL -o /dev/null -w "HTTP status for new tag: %{http_code}\n" \
  "https://registry.hub.docker.com/v2/repositories/axolotlai/axolotl/tags/main-py3.11-cu124-2.6.0"

Length of output: 276

Remove stale Docker tag reference in documentation

Verified that the new Docker tag (main-py3.11-cu124-2.6.0) exists on Docker Hub (HTTP 200). However, there’s still a reference to the old tag in the docs:

• docs/docker.qmd:78

Please update it as follows:

- `main-py3.11-cu124-2.5.1`
+ `main-py3.11-cu124-2.6.0`
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
docker_tag = "main-py3.11-cu124-2.6.0"
--- a/docs/docker.qmd
+++ b/docs/docker.qmd
@@ -75,7 +75,7 @@
<!-- (other content above) -->
-`main-py3.11-cu124-2.5.1`
+`main-py3.11-cu124-2.6.0`
<!-- (other content below) -->
🤖 Prompt for AI Agents 
In src/axolotl/cli/cloud/modal_.py at line 85, update the docker_tag variable to
"main-py3.11-cu124-2.6.0" as already done. Then, search the entire repository
for any remaining references to the old tag "main-py3.11-cu124-2.5.1" and
replace them with the new tag. Specifically, update the reference in
docs/docker.qmd at line 78 to use the new tag "main-py3.11-cu124-2.6.0" to
ensure consistency and remove stale references.

if self.config.docker_tag:
docker_tag = self.config.docker_tag
docker_image = f"axolotlai/axolotl:{docker_tag}"
Expand Down