feat(doc): update docker tag examples#2851
Conversation
|
""" WalkthroughThe documentation for Docker image tags was updated to include new and alternative tags for both base and main images, reflecting the availability of updated versions. The tagged release version reference was also changed from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/docker.qmd (3)
11-13: Capitalize “PyTorch” for brand correctnessMinor nit: “PyTorch” is the canonical spelling (capital “T”).
-For Blackwell GPUs, please use the tags with Pytorch 2.7.1 and CUDA 12.8. +For Blackwell GPUs, please use the tags with PyTorch 2.7.1 and CUDA 12.8.
33-38: Keep base-image tag examples ordered & scopedNice addition of the cu128 example.
To reduce visual scanning cost, consider ordering the list by CUDA version (desc) and, within that, by PyTorch version. This keeps the Blackwell-focused tag (cu128-2.7.1) clearly on top and prevents the oldercu126-2.6.0from appearing between two 2.7.1 examples.
75-79: Apply the same ordering to “main” image tagsSame comment as above: ordering the
main-*examples by CUDA version first (cu128➜cu126➜cu124) and then by PyTorch version makes it easier for readers to spot the recommended tag quickly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/docker.qmd(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: preview
🔇 Additional comments (1)
docs/docker.qmd (1)
85-85: Confirm version bump consistency across docsThe tagged release example now shows
0.10.1. Please verify that all other documentation sections (e.g., CHANGELOG, README badges) and any automation referring to the previous0.9.2tag are updated accordingly.
|
@coderabbitai , can you check where the ordering needs to be? I think it's already ordered across sections by cuda then torch. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 3393 @NanoCode012, you're absolutely correct! After examining the Current ordering pattern:
Base image tags:
Main image tags:
This ordering is logical and user-friendly, as it prioritizes the newest CUDA versions first (important for Blackwell GPU compatibility), followed by the newest PyTorch versions within each CUDA group. No reordering is needed! 👍 |
Description
We encouraged users to use cu128 for Blackwell but didn't provide example tags. This PR adds that.
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Summary by CodeRabbit