Add interfaces for easy expansion #2007
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@binxiaojiao |
6 tasks
rh101
reviewed
Jul 11, 2024
| @@ -322,6 +322,10 @@ class AX_DLL Mesh : public Object | |||
| std::vector<float> _spotLightUniformRangeInverseValues; | |||
|
|
|||
| std::string _texFile; | |||
|
|
|||
| // add by binxiaojiao | |||
There was a problem hiding this comment.
Comments like this should not be added, since it doesn't add extra useful information to the code
rh101
reviewed
Jul 11, 2024
|
|
||
| // add by binxiaojiao | ||
| public: | ||
| std::function<void()>& GetVisibleChanged() { return _visibleChanged; } |
There was a problem hiding this comment.
This should follow the convention used in Axmol, which is to use a lowercase first character, so it should be getVisibleChanged()
There was a problem hiding this comment.
I prefer public callback like engine callback renderer comnand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.