Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all AXLOG/printf to AXLOGD (without .\core, .\3rdparty) #2020

Merged
merged 90 commits into from
Jul 11, 2024
Merged

Rename all AXLOG/printf to AXLOGD (without .\core, .\3rdparty) #2020

merged 90 commits into from
Jul 11, 2024

Conversation

aismann
Copy link
Contributor

@aismann aismann commented Jul 5, 2024

Describe your changes

Rename all AXLOG to AXLOGD (without .\core)

Issue ticket number and link

#2019

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@aismann
Copy link
Contributor Author

aismann commented Jul 10, 2024

@halx99
Should I replace also .\extensions\spine\runtime ?

image

@aismann
Copy link
Contributor Author

aismann commented Jul 10, 2024

If no more changes want by you: I'm finished. => Its Ready for review now

Not changed (printf(...)):
image
and at the moment 'spine'=> Waiting to your feedback
image

@aismann aismann marked this pull request as ready for review July 10, 2024 04:29
@aismann aismann changed the title Rename all AXLOG to AXLOGD (without .\core) Rename all AXLOG/some printf to AXLOGD(without .\core) Jul 10, 2024
@aismann aismann changed the title Rename all AXLOG/some printf to AXLOGD(without .\core) Rename all AXLOG/printf to AXLOGD(without .\core) Jul 10, 2024
@aismann aismann changed the title Rename all AXLOG/printf to AXLOGD(without .\core) Rename all AXLOG/printf to AXLOGD (without .\core, .\3rdparty) Jul 10, 2024
@aismann
Copy link
Contributor Author

aismann commented Jul 10, 2024

@halx99
I belive some copyright lines be missed.
Should I add it too?

@halx99
Copy link
Collaborator

halx99 commented Jul 11, 2024

@halx99 I belive some copyright lines be missed. Should I add it too?

sure, you can

@aismann
Copy link
Contributor Author

aismann commented Jul 11, 2024

Add lot of Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md). lines

@halx99 @rh101
Im finished. No more changes planed.
Please merge after review.

@aismann
Copy link
Contributor Author

aismann commented Jul 11, 2024

@halx99
I add the copyright here for mesh.cpp/h too.
Merge of PR: Add interfaces for easy expansion #2007 can start too?

I have no direct access for editng to PR #2007

@halx99 halx99 merged commit fe0adcb into axmolengine:dev Jul 11, 2024
15 checks passed
@halx99
Copy link
Collaborator

halx99 commented Jul 11, 2024

@halx99 I add the copyright here for mesh.cpp/h too. Merge of PR: Add interfaces for easy expansion #2007 can start too?

I have no direct access for editng to PR #2007

You don't need care about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all AXLOG to AXLOGD (there be 417 without .\core)
4 participants