-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interfaces for easy expansion #2007
base: dev
Are you sure you want to change the base?
Changes from all commits
6f1cfe6
55cf2aa
24a41e7
de34e56
9462ed6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -322,6 +322,10 @@ class AX_DLL Mesh : public Object | |
std::vector<float> _spotLightUniformRangeInverseValues; | ||
|
||
std::string _texFile; | ||
|
||
// add by binxiaojiao | ||
public: | ||
std::function<void()>& GetVisibleChanged() { return _visibleChanged; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should follow the convention used in Axmol, which is to use a lowercase first character, so it should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer public callback like engine callback renderer comnand |
||
}; | ||
|
||
// end of 3d group | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments like this should not be added, since it doesn't add extra useful information to the code