Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Rust Edition 2021 #1268

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Update to Rust Edition 2021 #1268

merged 2 commits into from
Mar 22, 2022

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Mar 22, 2022 •
edited
Loading

Motivation and Context

#1154

Description

Update to Rust Edition 2021

Testing

ran existing tests

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi
update: set rust edition to 2021
f6c9391 
update: strict param of intoCrate to set clippy to set #![deny(clippy::all)]
@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -11.73% 35337.98 40033.93
Total requests -11.76% 3183092 3607114
Total errors NaN% 0 0
Total successes -11.76% 3183092 3607114
Average latency ms 10.34% 0.96 0.87
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -39.79% 16.9 28.07
Stdev latency ms -10.26% 0.7 0.78
Transfer Mb -11.76% 330.88 374.96
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@Velfi Velfi marked this pull request as ready for review March 22, 2022 18:59
@Velfi Velfi requested review from a team as code owners March 22, 2022 18:59
@Velfi Velfi enabled auto-merge (squash) March 22, 2022 21:00
@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 5.30% 84076.12 79843.32
Total requests 5.26% 7570552 7192218
Total errors NaN% 0 0
Total successes 5.26% 7570552 7192218
Average latency ms 55.88% 1.06 0.68
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 28.10% 25.89 20.21
Stdev latency ms 71.05% 1.95 1.14
Transfer Mb 5.26% 786.96 747.63
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@Velfi Velfi merged commit b2c9896 into main Mar 22, 2022
@Velfi Velfi deleted the update/to-edition-2021 branch March 22, 2022 21:29
@Velfi Velfi mentioned this pull request Mar 22, 2022
Closed
david-perez added a commit that referenced this pull request Apr 19, 2022
@david-perez
Use Rust 2021 edition for pre-commit's rustfmt
ee03945 
In #1268, runtime crates were updated to Rust 2021 edition.
This was referenced Apr 19, 2022
Merged
Closed
rcoh added a commit that referenced this pull request Apr 21, 2022
@david-perez @rcoh
Use Rust 2021 edition for pre-commit's rustfmt (#1328)
125328d 
In #1268, runtime crates were updated to Rust 2021 edition.

Co-authored-by: Russell Cohen <[email protected]>
david-perez added a commit that referenced this pull request Sep 12, 2022
@david-perez
Use Rust 2021 edition with rustfmt in CI
7511788 
We've long migrated to the 2021 edition everywhere. See PRs #1388, #1328,
and #1268.

See issue #1332 too.
@david-perez david-perez mentioned this pull request Sep 12, 2022
Merged
david-perez added a commit that referenced this pull request Sep 13, 2022
@david-perez
Use Rust 2021 edition with rustfmt in CI (#1728)
b4ac306 
We've long migrated to the 2021 edition everywhere. See PRs #1388, #1328,
and #1268.

See issue #1332 too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcoh rcoh rcoh approved these changes

@jdisanti jdisanti jdisanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velfi @jdisanti @rcoh