Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rust 2021 edition for pre-commit's rustfmt #1328

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

david-perez
Copy link
Contributor

In #1268, runtime crates were updated to Rust 2021 edition.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

In #1268, runtime crates were updated to Rust 2021 edition.
@david-perez david-perez requested a review from a team as a code owner April 19, 2022 15:16
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -20.89% 56726.17 71709.25
Total requests -20.93% 5108934 6460944
Total errors NaN% 0 0
Total successes -20.93% 5108934 6460944
Average latency ms -41.12% 0.63 1.07
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -21.99% 16.5 21.15
Stdev latency ms -66.48% 0.6 1.79
Transfer Mb -20.93% 531.08 671.62
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Copy link
Contributor

@Velfi Velfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks for catching this, sorry I missed it

@rcoh rcoh enabled auto-merge (squash) April 21, 2022 13:23
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -6.60% 77449.29 82920.84
Total requests -6.61% 6974650 7468024
Total errors NaN% 0 0
Total successes -6.61% 6974650 7468024
Average latency ms -13.08% 0.93 1.07
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms -10.24% 21.22 23.64
Stdev latency ms -18.42% 1.55 1.9
Transfer Mb -6.61% 725.02 776.3
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

@rcoh rcoh merged commit 125328d into main Apr 21, 2022
@rcoh rcoh deleted the davidpz-use-rust-2021-edition-for-pre-commit's-`rustfmt` branch April 21, 2022 13:52
david-perez added a commit that referenced this pull request Sep 12, 2022
We've long migrated to the 2021 edition everywhere. See PRs #1388, #1328,
and #1268.

See issue #1332 too.
david-perez added a commit that referenced this pull request Sep 13, 2022
We've long migrated to the 2021 edition everywhere. See PRs #1388, #1328,
and #1268.

See issue #1332 too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants