Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate crates with Rust 2021 edition #1332

Closed
david-perez opened this issue Apr 20, 2022 · 0 comments · Fixed by #1388
Closed

Generate crates with Rust 2021 edition #1332

david-perez opened this issue Apr 20, 2022 · 0 comments · Fixed by #1388
Assignees
@82marbag

Comments

@david-perez
Copy link
Contributor

We currently generate crates using Rust 2018 edition:

https://github.com/awslabs/smithy-rs/blob/2931c9e1e68bfc74618e427ecb6d6a86a6a35a5f/codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/CargoTomlGenerator.kt#L63-L63

In #1268, runtime crates were updated to Rust 2021 edition.
@82marbag 82marbag self-assigned this May 12, 2022
82marbag pushed a commit that referenced this issue May 13, 2022
Update crates to Rust 2021
e9066ed 
Generate crates using Rust 2021 instead of Rust 2018
Remove use std::convert::TryFrom which is in the prelude

Closes #1332

Signed-off-by: Daniele Ahmed <[email protected]>
@82marbag 82marbag mentioned this issue May 13, 2022
Merged
2 tasks
82marbag pushed a commit that referenced this issue May 13, 2022
Update crates to Rust 2021
1adfb25 
Generate crates using Rust 2021 instead of Rust 2018
Remove use std::convert::TryFrom which is in the prelude

Closes #1332

Signed-off-by: Daniele Ahmed <[email protected]>
82marbag added a commit that referenced this issue May 13, 2022
@82marbag
Update crates to Rust 2021 (#1388)
154c5d1 
Generate crates using Rust 2021 instead of Rust 2018
Remove use std::convert::TryFrom which is in the prelude

Closes #1332

Signed-off-by: Daniele Ahmed <[email protected]>
david-perez added a commit that referenced this issue Sep 12, 2022
@david-perez
Use Rust 2021 edition with rustfmt in CI
7511788 
We've long migrated to the 2021 edition everywhere. See PRs #1388, #1328,
and #1268.

See issue #1332 too.
@david-perez david-perez mentioned this issue Sep 12, 2022
Merged
david-perez added a commit that referenced this issue Sep 13, 2022
@david-perez
Use Rust 2021 edition with rustfmt in CI (#1728)
b4ac306 
We've long migrated to the 2021 edition everywhere. See PRs #1388, #1328,
and #1268.

See issue #1332 too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@82marbag 82marbag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update crates to Rust 2021 smithy-lang/smithy-rs
2 participants
@david-perez @82marbag