Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[request]: Migrate to Rust 2021 edition #490

Closed
overheat opened this issue Mar 17, 2022 · 4 comments
Closed

[request]: Migrate to Rust 2021 edition #490

overheat opened this issue Mar 17, 2022 · 4 comments
Labels
feature-request A feature should be added or improved. low-priority This issue is low-priority and will be addressed once we have fewer high-priority tasks

Comments

@overheat
Copy link

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Tell us about your request

Migrate to Rust 2021 edition.
Looks lots of examples works under 2021 edition now.

Tell us about the problem you're trying to solve.

modernize.

Are you currently working around this issue?

Yes.

Additional context

No response
@overheat overheat added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2022
@Velfi
Copy link
Contributor

Velfi commented Mar 18, 2022

Hey @overheat, this isn't currently a high-priority issue for us and we don't expect to get to it soon but we encourage you to submit a PR if this is important to you.

@Velfi Velfi added low-priority This issue is low-priority and will be addressed once we have fewer high-priority tasks and removed needs-triage This issue or PR still needs to be triaged. labels Mar 18, 2022
@Velfi
Copy link
Contributor

Velfi commented Mar 22, 2022

I had some free time and implemented this in smithy-rs#1268. It'll go out in the next release

@Velfi Velfi added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed pending-release This issue will be fixed by an approved PR that hasn't been released yet. labels Apr 4, 2022
@rcoh
Copy link
Contributor

rcoh commented Apr 15, 2022

released in v0.10.1

@rcoh rcoh closed this as completed Apr 15, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. low-priority This issue is low-priority and will be addressed once we have fewer high-priority tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rcoh @Velfi @overheat