Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode illegal characters inside cookies and change cookies parsing logic #46

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Encode illegal characters inside cookies and change cookies parsing logic #46

merged 2 commits into from
Dec 5, 2022

Conversation

borisfba
Copy link
Member

@borisfba borisfba commented Dec 1, 2022

Issue # (if available):
#43

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@borisfba borisfba requested a review from jeandek December 1, 2022 07:19
jeandek
jeandek approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@jeandek jeandek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckifer ckifer mentioned this pull request Dec 2, 2022
Closed
ckifer
ckifer approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@ckifer ckifer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thanks so much for doing this!

Should also close my draft PR #44

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@borisfba borisfba merged commit 15d2534 into main Dec 5, 2022
@borisfba borisfba deleted the cookie-encoding-bug branch December 5, 2022 14:13
@borisfba borisfba added the bug Something isn't working label Dec 5, 2022
@borisfba borisfba added this to the 1.3.1 milestone Dec 5, 2022
@ckifer ckifer mentioned this pull request Dec 5, 2022
Closed
borisfba pushed a commit that referenced this pull request Dec 5, 2022
@borisfba
Encode illegal characters inside cookies and change cookies parsing l…
326019d 
…ogic (#46)

* Make produced cookies RFC 6265 compliant by URI encoding illegal characters.
* Revise cookies parsing logic to fix issues with subdomains (#43 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckifer ckifer ckifer approved these changes

@jeandek jeandek jeandek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@borisfba @jeandek @ckifer