fix: incorrect idToken regex with subdomains #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Coltin, Thank you for your contribution. In future, we plan to URI encode cookies and avoid using Regex to parse it, because we have one more underlying issue with usernames containing illegal characters. Unfortunately, we cannot commit to a timeline for when it would be released. |
|
Closing since #46 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available):
#43
Description of changes:
idTokento be returned when expecting theidTokenfrom the subdomainProposed Regex solution
\.[^.]+\.idToken=([^;]+)fails test here when there are.characters in the username. Need better regex before continuing.Maybe there is a better way to parse idToken?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.