Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SameSite directive #47

Closed
ckifer opened this issue Dec 2, 2022 · 8 comments
Closed

Support SameSite directive #47

ckifer opened this issue Dec 2, 2022 · 8 comments

Comments

@ckifer
Copy link
Contributor

ckifer commented Dec 2, 2022

What would you like to be added:

As a user with secure websites I would like control over all common cookie directives. Recently HttpOnly was added to the library - this would be to support SameSite as well.

Why is this needed:

  • Provide flexible configuration to cognito-at-edge
  • improve security config options
@ckifer
Copy link
Contributor Author

ckifer commented Dec 2, 2022

Should probably wait on #46 to merge

@ckifer
Copy link
Contributor Author

ckifer commented Dec 13, 2022

Resolved in #50

@ckifer ckifer closed this as completed Dec 13, 2022
@fknittel
Copy link
Contributor

@ckifer Thanks for the enhancement! Do you know whether this will be released anytime soon? We're keen on using it in our project.

@ckifer
Copy link
Contributor Author

ckifer commented Feb 13, 2023

I also need to use it on next release - @jeandek or @borisfba ?

@jeandek
Copy link
Contributor

jeandek commented Feb 14, 2023

@ckifer @fknittel : Sorry about the delay. I will try to publish the new version by the end of the week (probably Thursday).

@ckifer
Copy link
Contributor Author

ckifer commented Feb 14, 2023

Thanks!

@jeandek
Copy link
Contributor

jeandek commented Feb 20, 2023

@ckifer @fknittel We published version 1.3.2 of the package this morning. Here are the change notes.

@ckifer
Copy link
Contributor Author

ckifer commented Feb 20, 2023

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants