-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for namespace, metric and timestamp #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve namespace validation add tests
evanuk
reviewed
Sep 1, 2022
replace faker with non deprecated faker update repo to comply with new eslint rules change isNaN to Number.isNaN in validator change metric max/min vals
Update:
Interesting read on what happened to faker and how the creator starting pushing malicious updates. |
evanuk
approved these changes
Sep 2, 2022
markkuhn
changed the title
Add validation for namespace and metric
Add validation for namespace, metric and timestamp
Sep 2, 2022
Himtanaya
approved these changes
Sep 6, 2022
This was referenced Sep 7, 2022
fix link to timestamp specs
Closed
This was referenced Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #131
Description of changes:
Adding validation for metrics and namespace since validating dimensions alone doesn't make sense.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.