Add validation for dimension values #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkuhn
changed the title
markkuhn
changed the title
Himtanaya
approved these changes
Aug 18, 2022
giancarlokc
reviewed
Aug 18, 2022
markkuhn
referenced
this pull request
in awslabs/aws-embedded-metrics-python
Aug 18, 2022
This reverts commit 47bf736.
gordonpn
reviewed
Aug 18, 2022
giancarlokc
reviewed
Aug 19, 2022
markkuhn
requested review from
gordonpn,
johnjang,
giancarlokc and
Himtanaya
and removed request for
Himtanaya
gordonpn
approved these changes
Aug 19, 2022
This was referenced Aug 19, 2022
Himtanaya
approved these changes
Aug 22, 2022
giancarlokc
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #68
Related issues:
Description of changes:
Add function to strip non-ascii characters and stringify numbers for dimension values.
[UPDATE] Instead of silently dropping non-compliant characters, the client will now throw an error if an invalid dimension is found according to specifications here (breaking change).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.