Add validation for namespace, metric and timestamp

.eslintrc

@@ -8,8 +8,7 @@
     "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended",
     "plugin:@typescript-eslint/recommended-requiring-type-checking",
-    "prettier",
-    "prettier/@typescript-eslint"
+    "prettier"
   ],
   "rules": {
     "@typescript-eslint/interface-name-prefix": "off"
@@ -24,7 +23,15 @@
         "@typescript-eslint/no-explicit-any": "off",
         "@typescript-eslint/no-non-null-assertion": "off",
         "@typescript-eslint/no-use-before-define": "off",
-        "@typescript-eslint/unbound-method": "off"
+        "@typescript-eslint/unbound-method": "off",
+        "@typescript-eslint/no-unsafe-member-access": "off",
+        "@typescript-eslint/no-unsafe-argument": "off",
+        "@typescript-eslint/no-unsafe-assignment": "off",
+        "@typescript-eslint/no-unsafe-call": "off",
+        "@typescript-eslint/no-unsafe-return": "off",
+        "@typescript-eslint/no-floating-promises": "off",
+        "@typescript-eslint/no-var-requires": "off",
+        "@typescript-eslint/ban-ts-comment": "off"
       }
     }
   ]

package.json

@@ -36,23 +36,23 @@
     "@datastructures-js/heap": "^4.0.2"
   },
   "devDependencies": {
+    "@faker-js/faker": "^7.5.0",
     "@types/faker": "^4.1.5",
     "@types/jest": "^26.0.22",
     "@types/node": "^12.0.8",
     "@types/validator": "^13.7.5",
-    "@typescript-eslint/eslint-plugin": "^2.23.0",
-    "@typescript-eslint/parser": "^2.23.0",
+    "@typescript-eslint/eslint-plugin": "^5.36.1",
+    "@typescript-eslint/parser": "^5.36.1",
     "aws-sdk": "^2.551.0",
-    "eslint": "^6.8.0",
-    "eslint-config-prettier": "^6.10.0",
-    "eslint-plugin-prettier": "^3.1.2",
-    "faker": "^4.1.0",
+    "eslint": "^8.23.0",
+    "eslint-config-prettier": "^8.5.0",
+    "eslint-plugin-prettier": "^4.2.1",
     "jest": "^26.6.3",
     "node-notifier": ">=8.0.1",
-    "npm-pack-zip": "^1.2.7",
-    "prettier": "^1.19.1",
+    "npm-pack-zip": "^1.3.0",
+    "prettier": "^2.7.1",
     "ts-jest": "^26.5.4",
-    "typescript": "^3.8.0",
+    "typescript": "^4.8.2",
     "validator": "^13.7.0",
     "y18n": ">=4.0.1"
   },

src/Constants.ts

@@ -14,10 +14,15 @@
  */
 
 export enum Constants {
+  MAX_DIMENSION_SET_SIZE = 30,
   MAX_DIMENSION_NAME_LENGTH = 250,
   MAX_DIMENSION_VALUE_LENGTH = 1024,
+  MAX_METRIC_NAME_LENGTH = 1024,
+  MAX_NAMESPACE_LENGTH = 256,
+  VALID_NAMESPACE_REGEX = '^[a-zA-Z0-9._#:/-]+$',
+  MAX_TIMESTAMP_PAST_AGE = 1209600000, // 2 weeks
+  MAX_TIMESTAMP_FUTURE_AGE = 7200000, // 2 hours
 
-  MAX_DIMENSION_SET_SIZE = 30,
   DEFAULT_NAMESPACE = 'aws-embedded-metrics',
   MAX_METRICS_PER_EVENT = 100,
   MAX_VALUES_PER_METRIC = 100,

src/config/__tests__/EnvironmentConfigurationProvider.test.ts

@@ -1,4 +1,4 @@
-import * as faker from 'faker';
+import { faker } from '@faker-js/faker';
 import Environments from '../../environment/Environments';
 
 beforeEach(() => {

src/environment/__tests__/DefaultEnvironment.test.ts

@@ -1,4 +1,4 @@
-import * as faker from 'faker';
+import { faker } from '@faker-js/faker';
 import config from '../../config/Configuration';
 import { DefaultEnvironment } from '../DefaultEnvironment';
 

src/environment/__tests__/ECSEnvironment.test.ts

@@ -1,4 +1,4 @@
-import * as faker from 'faker';
+import { faker } from '@faker-js/faker';
 import config from '../../config/Configuration';
 import { ECSEnvironment } from '../ECSEnvironment';
 import { MetricsContext } from '../../logger/MetricsContext';
@@ -199,7 +199,7 @@ describe('getName()', () => {
   test('returns formatted image name if available', async () => {
     // arrange
     const formattedImageName = `${faker.lorem.word()}:latest`;
-    const fullImageName = `${faker.random.number({
+    const fullImageName = `${faker.datatype.number({
       min: 0,
       max: 999999999999,
     })}.dkr.ecr.<region>.amazonaws.com/${formattedImageName}`;

src/environment/__tests__/LambdaEnvironment.test.ts

@@ -1,4 +1,4 @@
-import * as faker from 'faker';
+import { faker } from '@faker-js/faker';
 import { MetricsContext } from '../../logger/MetricsContext';
 import { LambdaEnvironment } from '../LambdaEnvironment';
 

src/environment/__tests__/LocalEnvironment.test.ts

@@ -1,4 +1,4 @@
-import * as faker from 'faker';
+import { faker } from '@faker-js/faker';
 import config from '../../config/Configuration';
 import { LocalEnvironment } from '../LocalEnvironment';
 

src/exceptions/DimensionSetExceededError.ts

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2019 Amazon.com, Inc. or its affiliates.
+ * Licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export class DimensionSetExceededError extends Error {
   constructor(msg: string) {
     super(msg);

src/exceptions/InvalidDimensionError.ts

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2019 Amazon.com, Inc. or its affiliates.
+ * Licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export class InvalidDimensionError extends Error {
   constructor(msg: string) {
     super(msg);

src/exceptions/InvalidMetricError.ts

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2019 Amazon.com, Inc. or its affiliates.
+ * Licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export class InvalidMetricError extends Error {
+    constructor(msg: string) {
+      super(msg);
+
+      // Set the prototype explicitly.
+      Object.setPrototypeOf(this, InvalidMetricError.prototype);
+    }
+  }
+

src/exceptions/InvalidNamespaceError.ts

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2019 Amazon.com, Inc. or its affiliates.
+ * Licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export class InvalidNamespaceError extends Error {
+    constructor(msg: string) {
+      super(msg);
+
+      // Set the prototype explicitly.
+      Object.setPrototypeOf(this, InvalidNamespaceError.prototype);
+    }
+  }
+

src/exceptions/InvalidTimestampError.ts

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2019 Amazon.com, Inc. or its affiliates.
+ * Licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export class InvalidTimestampError extends Error {
+    constructor(msg: string) {
+      super(msg);
+
+      // Set the prototype explicitly.
+      Object.setPrototypeOf(this, InvalidTimestampError.prototype);
+    }
+  }
+

src/logger/MetricValues.ts

@@ -1,5 +1,3 @@
-import { Unit } from '..';
-
 /*
  * Copyright 2019 Amazon.com, Inc. or its affiliates.
  * Licensed under the Apache License, Version 2.0 (the
@@ -15,6 +13,8 @@ import { Unit } from '..';
  * limitations under the License.
  */
 
+import { Unit } from '..';
+
 export class MetricValues {
   public values: number[];
   public unit: string;

src/logger/MetricsContext.ts

@@ -83,6 +83,7 @@ export class MetricsContext {
   }
 
   public setNamespace(value: string): void {
+    Validator.validateNamespace(value);
     this.namespace = value;
   }
 
@@ -91,6 +92,7 @@ export class MetricsContext {
   }
 
   public setTimestamp(timestamp: Date | number): void {
+    Validator.validateTimestamp(timestamp);
     this.timestamp = timestamp;
     this.meta.Timestamp = MetricsContext.resolveMetaTimestamp(timestamp);
   }
@@ -172,6 +174,8 @@ export class MetricsContext {
   }
 
   public putMetric(key: string, value: number, unit?: Unit | string): void {
+    Validator.validateMetric(key, value, unit);
+
     const currentMetric = this.metrics.get(key);
     if (currentMetric) {
       currentMetric.addValue(value);