Skip to content

Conversation

@maxday
Copy link
Member

@maxday maxday commented Nov 16, 2025

Description of changes:

Previously, we introduced a breaking change in aws/lambda-invoke-store to allow lazy loading a costly dependency (see awslabs/aws-lambda-invoke-store#13)
Now, it requires the store to be retrieved using an await operation. This change would force our callers to become async, leading to extensive refactoring and breaking changes in public-facing functions.

To maintain backward compatibility, we've updated the implementation to use globalThis.awslambda?.InvokeStore instead. This approach avoids the need for async operations while still accessing the store.

Test cases have been updated accordingly.

Some minor linting fix in the test file

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.31%. Comparing base (bd760ba) to head (b272b37).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files          36       36           
  Lines        1817     1817           
=======================================
  Hits         1532     1532           
  Misses        285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxday maxday marked this pull request as ready for review November 17, 2025 01:47
@maxday maxday requested a review from a team as a code owner November 17, 2025 01:47
@jj22ee jj22ee merged commit aa72b4f into aws:master Nov 17, 2025
13 checks passed
jj22ee pushed a commit that referenced this pull request Nov 28, 2025
* feat: use invoke-store from global

* fix: duplicate

* fix: bump @aws/lambda-invoke-store but used in devDependencies only (for testing)

* fix: package-lock.json

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants