Skip to content

feat: use invoke-store from global #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jj22ee merged 5 commits into from
Nov 17, 2025
Merged

feat: use invoke-store from global #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75d9ca5
feat: use invoke-store from global
maxday Nov 16, 2025
2f2f320
fix: duplicate
maxday Nov 16, 2025
1e5b975
fix: bump @aws/lambda-invoke-store but used in devDependencies only (…
maxday Nov 16, 2025
7040d7e
fix: package-lock.json
maxday Nov 16, 2025
b272b37
fix: lint
maxday Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 29 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions packages/core/lib/env/aws_lambda.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,9 @@ var LambdaUtils = require('../utils').LambdaUtils;
var Segment = require('../segments/segment');
var SegmentEmitter = require('../segment_emitter');
var SegmentUtils = require('../segments/segment_utils');

var logger = require('../logger');
const TraceID = require('../segments/attributes/trace_id');

const { InvokeStore } = require('@aws/lambda-invoke-store');

/**
* @namespace
* @ignore
Expand Down Expand Up @@ -82,7 +79,8 @@ var facadeSegment = function facadeSegment() {
};

segment.resolveLambdaTraceData = function resolveLambdaTraceData() {
const traceIdFromInvokeStore = InvokeStore.getXRayTraceId();
const invokeStore = globalThis.awslambda?.InvokeStore;
const traceIdFromInvokeStore = invokeStore?.getXRayTraceId();
const traceIdFromEnv = process.env._X_AMZN_TRACE_ID;
var xAmznLambda = traceIdFromInvokeStore ?? traceIdFromEnv;

Expand Down
4 changes: 3 additions & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@
"//": "@types/cls-hooked is exposed in API so must be in dependencies, not devDependencies",
"dependencies": {
"@aws-sdk/types": "^3.4.1",
"@aws/lambda-invoke-store": "^0.0.1",
"@smithy/service-error-classification": "^2.0.4",
"@types/cls-hooked": "^4.3.3",
"atomic-batcher": "^1.0.2",
"cls-hooked": "^4.2.2",
"semver": "^7.5.3"
},
"devDependencies": {
"@aws/lambda-invoke-store": "^0.2.0"
},
"scripts": {
"prepare": "npm run compile",
"compile": "tsc && npm run copy-lib && npm run copy-test",
Expand Down
Loading
Loading