add shapes to S3NeedsCustomUpdate and add devconfig #4149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #4145, branch: peterrsongg/petesong/phase-3-pr-3/1
stack-info: PR: #4146, branch: peterrsongg/petesong/phase-3-pr-3/2
stack-info: PR: #4147, branch: peterrsongg/petesong/phase-3-pr-3/3
stack-info: PR: #4148, branch: peterrsongg/petesong/phase-3-pr-3/4
stack-info: PR: #4149, branch: peterrsongg/petesong/phase-3-pr-3/5
peterrsongg
force-pushed
the
peterrsongg/petesong/phase-3-pr-3/5
branch
from
875e96a to
663b399
Compare
| { "AnalyticsAndOperator", 2 }, | ||
| { "IntelligentTieringAndOperator", 2} | ||
| }; | ||
| if (customUpdateShapes.TryGetValue(shape.Name, out int membersCount)) |
Member
There was a problem hiding this comment.
Why we are only checking the membersCount? What if the docs changed or the changed something with the validation and made them more open?
I know this isn't part of this PR and I'm not sure if I reviewed the first PR and missed it.
Contributor
Author
There was a problem hiding this comment.
hmm that is a good point, a doc change wouldn't trigger this validation. This is a short-term solution though. Longer term we need a trebuchet validator.
Contributor
There was a problem hiding this comment.
I am ok which this only until the customization flag is no longer automatically set on the feature for the reason you stated where we don't want to have validation failures. Please add a task to add the validator to the S3 project.
boblodgett
approved these changes
Nov 20, 2025
muhammad-othman
approved these changes
Nov 21, 2025
peterrsongg
changed the base branch from
peterrsongg/petesong/phase-3-pr-3/4
to
petesong/4145-4149
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds complex shapes to the S3NeedsCustomUpdate. Since these shapes are excluded from generation (or heavily customized). I'm backfilling those shapes that I missed in previous PRs so that the generator will throw an exception if any of these shapes are updated. This is a temporary solution. The longer term solution will work as a validator or an acknowledgment in the build system so that we don't mess up our preview build failure metrics.
Motivation and Context
Testing
Dry run for base branch passed
Screenshots (if appropriate)
Types of changes
Checklist
License