Generate GetBucketIntelligentTieringConfiguration

[peterrsongg]

Description

Generate GetBucketIntelligentTieringConfiguration

Motivation and Context

Testing

Dry run for base branch passed
Fuzz testing passed.
AI Prompt run

NOTE: doing IntelligentTiering validation changed the behavior. Previously, not setting this would call ListBucketIntelligentTieringConfiguration. Will call this out in the changelog.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[peterrsongg]

GetBucketInteligentTiering AI report

Breaking Changes Analysis Report

I have analyzed all 14 files affected in this PR migration from custom to generated S3 code. Here are the findings:

❌ BREAKING CHANGE #1: GetBucketIntelligentTieringConfigurationRequest.cs

File: sdk/src/Services/S3/Generated/Model/GetBucketIntelligentTieringConfigurationRequest.cs

Issue: IsSet method changed for string properties

Custom (deleted) code:

internal bool IsSetIntelligentTieringId()
{
    return !string.IsNullOrEmpty(this.intelligentTieringId);
}

Generated code:

internal bool IsSetIntelligentTieringId()
{
    return this._intelligentTieringId != null;
}

Impact: Per instruction #5, for request objects with string properties, changing IsSet from !string.IsNullOrEmpty to != null is a BREAKING CHANGE. This means an empty string ("") will now be considered "set" when previously it was not.

---

⚠️ POTENTIAL ISSUE #1: GetBucketIntelligentTieringConfigurationRequestMarshaller.cs

Files:

• Custom: sdk/src/Services/S3/Custom/Model/Internal/MarshallTransformations/GetBucketIntelligentTieringConfigurationRequestMarshaller.cs
• Generated: sdk/src/Services/S3/Generated/Model/Internal/MarshallTransformations/GetBucketIntelligentTieringConfigurationRequestMarshaller.cs

Issue: Different methods used to add the id query parameter

Custom (deleted) code:

request.AddSubResource("id", getBucketIntelligentTieringConfigurationRequest.IntelligentTieringId);

Generated code:

if (publicRequest.IsSetIntelligentTieringId())
    request.Parameters.Add("id", StringUtils.FromString(publicRequest.IntelligentTieringId));

Analysis: The custom code used AddSubResource() while generated uses request.Parameters.Add(). Both should add query parameters, but:

1. Generated code adds conditional check with IsSetIntelligentTieringId()
2. Generated code explicitly converts via StringUtils.FromString()

Recommendation: Verify that AddSubResource and request.Parameters.Add produce identical query string behavior for the id parameter.

---

⚠️ POTENTIAL ISSUE #2: TieringUnmarshaller.cs

File: sdk/src/Services/S3/Generated/Model/Internal/MarshallTransformations/TieringUnmarshaller.cs

Issue: Different unmarshaller used for Days property

Custom (deleted) code:

tiering.Days = IntUnmarshaller.GetInstance().Unmarshall(context);

Generated code:

var unmarshaller = NullableIntUnmarshaller.Instance;
unmarshalledObject.Days = unmarshaller.Unmarshall(context);

Analysis: The Tiering model's Days property is defined as int? (nullable int). The custom code used IntUnmarshaller which returns non-nullable int, while the generated correctly uses NullableIntUnmarshaller for nullable int. This is likely a BUG FIX in the generated code rather than a breaking change, as the custom implementation was technically incorrect for a nullable property. However, this changes unmarshalling behavior.

---

✅ NO ISSUES FOUND:

The following files have no breaking changes:

1. GetBucketIntelligentTieringConfigurationResponse.cs - IsSet methods use != null for object properties (responses exempt per instructions)
2. GetBucketIntelligentTieringConfigurationResponseUnmarshaller.cs - Functionally equivalent logic
3. IntelligentTieringConfigurationUnmarshaller.cs - Functionally equivalent logic
4. IntelligentTieringConfiguration.cs (model) - Properties are compatible
5. Tiering.cs (model) - Properties are compatible with nullable Days

---

Summary

Files Analyzed: 14 out of 14 (100%)

Confirmed Breaking Changes: 1

• IsSet method change for string property in request object

Potential Issues Requiring Verification: 2

• Different parameter addition methods in marshaller
• Different unmarshaller type for Days property (likely a fix, not a break)

Files With No Issues: 11

Critical Action Required: Fix the IsSet method for IntelligentTieringId in the generated request class to use !string.IsNullOrEmpty instead of != null to maintain backwards compatibility.

[peterrsongg]

not changing this to String.ISNullOREmpty because we check this in the marshaller and will throw an exception if the string is null or empty

[peterrsongg]

this is fine because Days must be specified for the AccessTier when you put the intelligenttiering configuration, meaning that if the AccessTier xmlElement is present on the Get side then there will always be a non-empty Days xml element