-
Notifications
You must be signed in to change notification settings - Fork 873
add shapes to S3NeedsCustomUpdate and add devconfig #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
peterrsongg
merged 5 commits into
petesong/4145-4149
from
peterrsongg/petesong/phase-3-pr-3/5
Nov 21, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
17ee8cf
generate PutBucketIntelligentTieringConfiguration
peterrsongg f8ef622
Generate GetBucketIntelligentTieringConfiguration
peterrsongg 43818b1
Generate ListBucketIntelligentTieringConfiguration
peterrsongg 367749a
Generate DeleteBucketIntelligentTiering
peterrsongg 663b399
add shapes to S3NeedsCustomUpdate and add devconfig
peterrsongg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
generator/.DevConfigs/0c5568ff-1b20-4cd6-a5cf-2e676424569a.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "services": [ | ||
| { | ||
| "serviceName": "S3", | ||
| "type": "patch", | ||
| "changeLogMessages": [ | ||
| "Generate 4 more S3 operations" | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 0 additions & 27 deletions
27
sdk/src/Services/S3/Custom/Model/DeleteBucketIntelligentTieringConfigurationResponse.cs
This file was deleted.
Oops, something went wrong.
93 changes: 0 additions & 93 deletions
93
sdk/src/Services/S3/Custom/Model/IntelligentTieringConfiguration.cs
This file was deleted.
Oops, something went wrong.
74 changes: 0 additions & 74 deletions
74
...l/MarshallTransformations/DeleteBucketIntelligentTieringConfigurationRequestMarshaller.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are only checking the
membersCount? What if the docs changed or the changed something with the validation and made them more open?I know this isn't part of this PR and I'm not sure if I reviewed the first PR and missed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm that is a good point, a doc change wouldn't trigger this validation. This is a short-term solution though. Longer term we need a trebuchet validator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok which this only until the customization flag is no longer automatically set on the feature for the reason you stated where we don't want to have validation failures. Please add a task to add the validator to the S3 project.