Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Sep 29, 2023

Motivation and Context

Since the release will be service by service, will start with S3/Polly on preSRA, making the Presigners be not dependent on new interfaces.

Modifications

So reverting SRA changes for Presigners from #4311. That change was necessary in the scope of #4311, but now is not necessary because of derived attributes change from #4396.

Testing

./mvnw clean install -pl :polly,:s3

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar marked this pull request as ready for review September 29, 2023 23:37
@gosar gosar requested a review from a team as a code owner September 29, 2023 23:37
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 492 Code Smells

84.6% 84.6% Coverage
4.5% 4.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar enabled auto-merge (squash) October 1, 2023 23:15
@gosar gosar merged commit cadb6ab into feature/master/sra-identity-auth Oct 1, 2023
@gosar gosar deleted the gosar/sra-ia-presigner-preSRA branch October 2, 2023 14:04
gosar added a commit that referenced this pull request Oct 3, 2023
gosar added a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants