-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DFSM] Support live updates on compute nodes. #6003
[DFSM] Support live updates on compute nodes. #6003
Conversation
a0bada2
to
0955b3c
Compare
4de4228
to
f786235
Compare
f786235
to
0848dd7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6003 +/- ##
===========================================
+ Coverage 90.20% 90.21% +0.01%
===========================================
Files 180 180
Lines 15808 15818 +10
===========================================
+ Hits 14259 14270 +11
+ Misses 1549 1548 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0848dd7
to
c0c3184
Compare
40f5bd7
to
c0c3184
Compare
…and cfn-hup without fleet stop. Signed-off-by: Giacomo Marciani <[email protected]>
Signed-off-by: Giacomo Marciani <[email protected]>
…er table. Signed-off-by: Giacomo Marciani <[email protected]>
…ueues rather than 50. Signed-off-by: Giacomo Marciani <[email protected]>
… compute nodes. Signed-off-by: Giacomo Marciani <[email protected]>
c0c3184
to
088ce00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. I verified that all the variables used in the user-data.sh of the compute node are still populated and that we just moved the variables required for dna.json.
Description of changes
Add support for live updates on compute nodes, using cfn-hup. In particular:
test_cluster_config_limits
to unblock these changes by reducing the maximum number of queues validated by the test from 50 to 46. We will revert this relaxation in a follow up PR where we will be able to move the content causing the limit breach from the template to the AMI.This PR relies on aws/aws-parallelcluster-cookbook#2614
Tests
test_update_slurm
succeeded.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.