Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFSM] Load pcluster envars in compute node user data to resolve cfn … #6023

Merged

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Jan 19, 2024

Description of changes

Load pcluster envars in compute node user data to resolve cfn bootstrap scripts, such as cfn-init.
The lack of this change impacts all OS, but AL2, because AL2 comes with its own installation of cfn bootstrap scripts already loaded in the PATH.

This change has been missed in #6003 because we validated that PR with AL2 only.

Tests

  • Without this fix cluster creation on Ubuntu2204 fails because compute node user data fails due to cfn-init not in the PATH.
  • With this fix the above creation succeeds.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani added bug skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jan 19, 2024
@gmarciani gmarciani requested review from a team as code owners January 19, 2024 11:25
@gmarciani gmarciani enabled auto-merge (rebase) January 19, 2024 11:26
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6733ba) 90.21% compared to head (7ce6a46) 90.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6023   +/-   ##
========================================
  Coverage    90.21%   90.21%           
========================================
  Files          180      180           
  Lines        15822    15822           
========================================
  Hits         14274    14274           
  Misses        1548     1548           
Flag Coverage Δ
unittests 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmarciani gmarciani merged commit 15c454a into aws:develop Jan 19, 2024
35 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/dfsm2/fix-compute-user-data branch January 19, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x bug skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants