Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFSM] Support live updates on compute nodes. #2614

Merged

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Jan 10, 2024

Description of changes

Add support for live updates on compute nodes, using cfn-hup. In particular:

  • added cfn-hup to supervisord programs in compute fleet.
  • emit dummy log line to prove that update is triggered in compute nodes.

This PR is related to aws/aws-parallelcluster#6003, where the cfn-hup config file is created.

Tests

  • Adapted rspec tests to cover the changes.
  • Manual testing: cluster creation + forced update verifying that the update succeeds and the log line is emitted.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef5d05f) 75.56% compared to head (fbd2e29) 75.56%.

❗ Current head fbd2e29 differs from pull request most recent head ffd9c73. Consider uploading reports for the commit ffd9c73 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2614   +/-   ##
========================================
  Coverage    75.56%   75.56%           
========================================
  Files           16       16           
  Lines         2132     2132           
========================================
  Hits          1611     1611           
  Misses         521      521           
Flag Coverage Δ
unittests 75.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmarciani gmarciani force-pushed the wip/mgiacomo/390/dfsm2/forced-update-0108 branch from fbd2e29 to ffd9c73 Compare January 15, 2024 11:20
@gmarciani gmarciani marked this pull request as ready for review January 15, 2024 11:21
@gmarciani gmarciani requested review from a team as code owners January 15, 2024 11:21
@gmarciani gmarciani enabled auto-merge (rebase) January 16, 2024 12:18
@gmarciani gmarciani merged commit 4886bfc into aws:develop Jan 16, 2024
28 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/390/dfsm2/forced-update-0108 branch January 16, 2024 13:18
hanwen-pcluste pushed a commit to hanwen-pcluste/aws-parallelcluster-cookbook that referenced this pull request Aug 14, 2024
cfn-hup log is useful when debugging cluster update failures. Since aws#2614, all nodes rely on cfn-hup, making have the log on CloudWatch important.

Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste pushed a commit that referenced this pull request Aug 15, 2024
cfn-hup log is useful when debugging cluster update failures. Since #2614, all nodes rely on cfn-hup, making have the log on CloudWatch important.

Signed-off-by: Hanwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants