[DFSM][Test] Add permissions required by DFSM to compute node role defined in 'cluster-roles.cfn.yaml'. #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined in 'cluster-roles.cfn.yaml'. In particular, added: - cloudformation:DescribeStackResource - dynamodb:UpdateItem - dynamodb:PutItem - dynamodb:GetItem Signed-off-by: Giacomo Marciani <[email protected]>
gmarciani
added
bug
skip-changelog-update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6022 +/- ##
========================================
Coverage 90.21% 90.21%
========================================
Files 180 180
Lines 15822 15822
========================================
Hits 14274 14274
Misses 1548 1548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
enrico-usai
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add permissions required by DFSM to compute node role defined in 'cluster-roles.cfn.yaml'.
In particular, added:
These permissions for compute nodes have been introduced in #6003
Tests
test_iam_rolespassed (previously failing due to the lack of the permissions added in this PR)Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.