feat(codebuild): cache sharing of CodeBuild projects #34257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
This reverts commit 08ffaa46d93fc896e7293c964b4f7c9381f3d25a.
Adds a clarification note that these properties are not strictly enforced at runtime, but are still required nonetheless. ### Issue aws#34645 Fixes aws#34645. ### Reason for this change [ECS docs](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#task_size) was recently updated to state that the CPU/Memory property is not enforced on Windows platforms, but are still required nonetheless. ### Description of changes Add note to the CPU and memory property of Fargate task definitions. ### Describe any new or updated permissions being added No permissions added or updated. ### Description of how you validated changes No tests needed as this is a documentation change. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes aws#31755. ### Reason for this change The dev dependency is outdated and creates issue for users wanting to use some of the aws-sdk packages in custom resources. ### Description of changes <!-- What code changes did you make? Have you made any important design decisions? What AWS use cases does this change enable? To enable the use cases, which AWS service features are utilized? --> The goal of this change is to update the outdated `aws-sdk-js-codemod` package to the latest available version (bumping the major version from 0.x.x to 2.x.x). The following changes have been made: 1. Updated the `aws-sdk-js-codemod` 1. Ran scripts/update-sdkv3-parameters-model.sh 1. Fixed incorrect IAM prefix generated for CloudWatch actions, see aws#33078 and doc: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/permissions-reference-cw.html 1. Set the feature flag `logApiResponseDataPropertyTrueDefault` to false (which is the default value) for the tests that needed a snapshot update, as there is a bug that causes the snapshots to be outdated: aws#30583 1. Ran the tests with `--update-on-failed` to update snasphots 1. Reverted the feature flag changes. ### Description of how you validated changes Ran the integration tests and updated the snapshots. - `framework-integ/test/aws-elasticloadbalancingv2/test/integ.alb.oidc.ts`: needs a valid domain so successfully deployed it on my personal account, then regenerated the snapshots with `--dry-run --force` - `packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ-cognito.template.json`: needs a valid domain so successfully deployed it on my personal account, then regenerated the snapshots with `--dry-run --force` ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Updates the L1 CloudFormation resource definitions with the latest changes from `@aws-cdk/aws-service-spec`
…ws#34691) ### Issue aws#34690 Closes aws#34690 ### Reason for this change PR aws#33384 released in version `2.200.1` of `@aws-cdk/region-info` imported `UnscopedValidationError` from `aws-cdk-lib/core/lib/errors`, but did not export `errors.js` properly from `aws-cdk-lib`. This resulted in the following error message when attempting to `import { Fact } from '@aws-cdk/region-info'` (`fact.ts` imports `UnscopedValidationError`). ``` ❯ node test.js node:internal/modules/cjs/loader:1228 throw err; ^ Error: Cannot find module 'aws-cdk-lib/core/lib/errors' Require stack: - /Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js - /Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/index.js - /Volumes/workplace/test-region-info-app/test.js at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15) at Module._load (node:internal/modules/cjs/loader:1051:27) at Module.require (node:internal/modules/cjs/loader:1311:19) at require (node:internal/modules/helpers:179:18) at Object.<anonymous> (/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js:8:18) at Module._compile (node:internal/modules/cjs/loader:1469:14) at Module._extensions..js (node:internal/modules/cjs/loader:1548:10) at Module.load (node:internal/modules/cjs/loader:1288:32) at Module._load (node:internal/modules/cjs/loader:1104:12) at Module.require (node:internal/modules/cjs/loader:1311:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js', '/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/index.js', '/Volumes/workplace/test-region-info-app/test.js' ] } Node.js v20.17.0 ``` ### Description of changes Exported `errors.js` from `packages/aws-cdk-lib/package.json`, which makes it available to `@aws-cdk/region-info`. ### Describe any new or updated permissions being added None. ### Description of how you validated changes Tested by hand after making this code change, using example code from the linked issue. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ozelalisen
previously requested changes
Jul 9, 2025
@ozelalisen Thank you for your review! I'll fix it later. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@ozelalisen Could you please confirm again? |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-community-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
Cloudformation supports for configuring cache namespace for CodeBuild projects.
This feature is used for sharing the same cache across multiple projects.
https://docs.aws.amazon.com/codebuild/latest/userguide/caching-s3.html#caching-s3-sharing
Description of changes
cacheNamespacetoBucketCacheOptionsDescribe any new or updated permissions being added
None
Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license