-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: export errors to make it available in region-info/lib/fact.ts #34691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue #34690
Closes #34690
Reason for this change
PR #33384 released in version
2.200.1
of@aws-cdk/region-info
importedUnscopedValidationError
fromaws-cdk-lib/core/lib/errors
, but did not exporterrors.js
properly fromaws-cdk-lib
. This resulted in the following error message when attempting toimport { Fact } from '@aws-cdk/region-info'
(fact.ts
importsUnscopedValidationError
).Description of changes
Exported
errors.js
frompackages/aws-cdk-lib/package.json
, which makes it available to@aws-cdk/region-info
.Describe any new or updated permissions being added
None.
Description of how you validated changes
Tested by hand after making this code change, using example code from the linked issue.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license