Skip to content

Conversation

@Abogical
Copy link
Member

Adds a clarification note that these properties are not strictly enforced at runtime, but are still required nonetheless.

Issue #34645

Fixes #34645.

Reason for this change

ECS docs was recently updated to state that the CPU/Memory property is not enforced on Windows platforms, but are still required nonetheless.

Description of changes

Add note to the CPU and memory property of Fargate task definitions.

Describe any new or updated permissions being added

No permissions added or updated.

Description of how you validated changes

No tests needed as this is a documentation change.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Adds a clarification note that these properties are not strictly enforced at runtime, but are still required nonetheless.
@aws-cdk-automation aws-cdk-automation requested a review from a team June 11, 2025 13:07
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jun 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Abogical Abogical changed the title docs(ecs): Add note for windows tasks CPU/Memory requirement docs(ecs): add note for windows tasks CPU/Memory requirement Jun 11, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 11, 2025 13:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 11, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 11, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e95c557
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f4dc7e2 into main Jun 11, 2025
16 checks passed
@mergify mergify bot deleted the fix-ecs-windows-docs branch June 11, 2025 15:25
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ecs: Unclear requirement for Fargate Windows task-level CPU/Memory properties

3 participants