test: add logs to flakey test #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
approved these changes
Apr 11, 2023
brunos-bq
reviewed
Apr 11, 2023
| assertTrue(instanceIDs.size() > 0); | ||
| final String nextWriterId = instanceIDs.get(0); | ||
|
|
||
| LOGGER.info("currentConnectionObject: " + conn.unwrap(Connection.class)); |
Contributor
There was a problem hiding this comment.
NIT:
is it something that could be displayed all in one line?
it looks like those are logs mostly for debugging purposes? shouldn't it be finer/finest instead of info?
| () -> Messages.get( | ||
| "ClusterAwareReaderFailoverHandler.successfulReaderConnection", | ||
| new Object[] {this.newHost.getUrl()})); | ||
| LOGGER.fine("New reader connection object: " + conn); |
Contributor
There was a problem hiding this comment.
What's the goal/interest behind this log line?
Is the object supposed to have changed or remained? are we looking at any property on that object?
Contributor
Author
There was a problem hiding this comment.
To look at the hashcode of this object and to compare it with the connection we get after failover in AuroraFailoverTest.
karenc-bq
force-pushed
the
test/add_logs_to_flakey_test
branch
from
29f6f0c to
2f3b1e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add logs to flakey test so we can acquire more information when the test fails.
Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.