Skip to content

Commit 7b00497

Browse files
authored
test: add logs to flakey test (#395)
Add logs to flakey test so we can acquire more information when the test fails.
1 parent 5a2e478 commit 7b00497

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

wrapper/src/main/java/software/amazon/jdbc/plugin/failover/ClusterAwareReaderFailoverHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,7 @@ public ReaderFailoverResult call() {
402402
() -> Messages.get(
403403
"ClusterAwareReaderFailoverHandler.successfulReaderConnection",
404404
new Object[] {this.newHost.getUrl()}));
405+
LOGGER.fine("New reader connection object: " + conn);
405406
return new ReaderFailoverResult(conn, this.newHost, true);
406407
} catch (SQLException e) {
407408
pluginService.setAvailability(newHost.asAliases(), HostAvailability.NOT_AVAILABLE);

wrapper/src/test/java/integration/refactored/container/tests/AuroraFailoverTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,14 @@ public void test_DataSourceWriterConnection_BasicFailover()
517517
assertTrue(instanceIDs.size() > 0);
518518
final String nextWriterId = instanceIDs.get(0);
519519

520+
LOGGER.fine("currentConnectionObject: " + conn.unwrap(Connection.class));
521+
LOGGER.fine("initialWriterInstanceInfo endpoint: " + initialWriterInstanceInfo.getEndpoint());
522+
LOGGER.fine("currentConnectionId: " + currentConnectionId);
523+
LOGGER.fine("nextWriterId: " + nextWriterId);
524+
LOGGER.fine("nominatedWriterId: " + nominatedWriterId);
525+
526+
assertNotEquals(initialWriterInstanceInfo.getInstanceId(), currentConnectionId);
520527
assertEquals(nextWriterId, currentConnectionId);
521-
assertEquals(nominatedWriterId, currentConnectionId);
522528

523529
assertTrue(conn.isValid(IS_VALID_TIMEOUT));
524530
}

wrapper/src/test/resources/logging-test.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,4 @@ integration.container.aurora.postgres.AuroraPostgresBaseTest.level=FINEST
3131
integration.refactored.level=FINEST
3232
integration.refactored.container.tests.ReadWriteSplittingPerformanceTest.level=FINEST
3333
integration.refactored.host.TestEnvironment.level=FINEST
34+
integration.refactored.container.tests.AuroraFailoverTest.level=FINEST

0 commit comments

Comments
 (0)