Skip to content

test: add logs to flakey test #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karenc-bq merged 1 commit into from
Apr 11, 2023
Merged

test: add logs to flakey test #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...src/main/java/software/amazon/jdbc/plugin/failover/ClusterAwareReaderFailoverHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ public ReaderFailoverResult call() {
() -> Messages.get(
"ClusterAwareReaderFailoverHandler.successfulReaderConnection",
new Object[] {this.newHost.getUrl()}));
LOGGER.fine("New reader connection object: " + conn);
Copy link
Contributor

@brunos-bq brunos-bq Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the goal/interest behind this log line?
Is the object supposed to have changed or remained? are we looking at any property on that object?

Copy link
Contributor Author

@karenc-bq karenc-bq Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To look at the hashcode of this object and to compare it with the connection we get after failover in AuroraFailoverTest.

return new ReaderFailoverResult(conn, this.newHost, true);
} catch (SQLException e) {
pluginService.setAvailability(newHost.asAliases(), HostAvailability.NOT_AVAILABLE);
Expand Down
8 changes: 7 additions & 1 deletion wrapper/src/test/java/integration/refactored/container/tests/AuroraFailoverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,8 +517,14 @@ public void test_DataSourceWriterConnection_BasicFailover()
assertTrue(instanceIDs.size() > 0);
final String nextWriterId = instanceIDs.get(0);

LOGGER.fine("currentConnectionObject: " + conn.unwrap(Connection.class));
LOGGER.fine("initialWriterInstanceInfo endpoint: " + initialWriterInstanceInfo.getEndpoint());
LOGGER.fine("currentConnectionId: " + currentConnectionId);
LOGGER.fine("nextWriterId: " + nextWriterId);
LOGGER.fine("nominatedWriterId: " + nominatedWriterId);

assertNotEquals(initialWriterInstanceInfo.getInstanceId(), currentConnectionId);
assertEquals(nextWriterId, currentConnectionId);
assertEquals(nominatedWriterId, currentConnectionId);

assertTrue(conn.isValid(IS_VALID_TIMEOUT));
}
Expand Down
1 change: 1 addition & 0 deletions wrapper/src/test/resources/logging-test.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ integration.container.aurora.postgres.AuroraPostgresBaseTest.level=FINEST
integration.refactored.level=FINEST
integration.refactored.container.tests.ReadWriteSplittingPerformanceTest.level=FINEST
integration.refactored.host.TestEnvironment.level=FINEST
integration.refactored.container.tests.AuroraFailoverTest.level=FINEST