merge from dev and minor logging changes #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev into feature branch
EFS auth capability and related model updates
Merge branch 'dev' into feature/efs-aws-vpc
Implemented dependency logic so that EFS type volume task resource wait for pause container to be finished.
1. Remove UpdateAppliedStatus from task resource interface as it is unnecessary. 2. Remove returned error from BuildContainerDependency method since it doesn't really need to return an error. 3. Don't add namespace pause container as efs volume resource's dependency. 4. Minor refactor and cleanup.
Code changes for the volume task resource to use information from the task to invoke the ecs volume plugin to create the EFS volume, with transit encryption, transit encryption port, iam, network namespace supported. Transit encryption, transit encryption port and iam are supported via passing options to mount helper constructed from task payload. Options are constructed when the volume task resource is initialized during PostUnmarshalTask. To support mounting EFS in task network namespace for task in awsvpc network mode, the task network namespace handle is passed as another option to the mount helper. The pause container pid is saved in the volume task resource when pause container is transitioning to RESOURCE_PROVISION, and the pid is persisted to state file. Refactor EFS related logic into a separate file for readability.
Initialize the updated volume task resource with efs volume information from task payload. Extract and refactor some of the common logic in task_test.go to a separate file task_test_utils.go for readability.
Add volume plugin capabilties based on the value specified in ECS_VOLUME_PLUGIN_CAPABILITIES env.
Implement task resource container dependency
Integrate with ECS Volume Plugin for EFS volume
Merge branch 'feature/efs-aws-vpc' into dev
add v4 metadata feature and tests
fenxiong
approved these changes
Mar 23, 2020
yhlee-aws
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Implementation details
N/A
Testing
make testsuccessfulNew tests cover the changes: N/A
Description for the changelog
N/A
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.