Stats engine: only skip container on cpu/mem errors #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
approved these changes
Mar 6, 2020
fierlion
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #2366 changed the behavior of stats gathering to skip the container in the situation that storage stats gathering failed.
To keep behavior consistent, we will continue to only skip if cpu/mem stats fail.
This PR also fixes the behavior where network/storage stats were being assigned even when there were errors.
Testing
New tests cover the changes: no
Unfortunately the metrics Queue is a struct and not an interface, and thus can't be mocked without significant code refactoring.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.