Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v4 metadata feature and tests #2396

Merged
merged 6 commits into from
Mar 23, 2020
Merged

add v4 metadata feature and tests #2396

merged 6 commits into from
Mar 23, 2020

Conversation

cyastella
Copy link
Contributor

Summary

Merge feature branch v4_metadata into dev.
Individual changes have all been separately reviewed.

Implementation details

#2357
#2370
#2371
#2376
#2385
#2389

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@fenxiong fenxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to use merge rather than rebase

@cyastella cyastella merged commit f18c142 into dev Mar 23, 2020
@cyastella cyastella added this to the 1.39.0 milestone Mar 31, 2020
@cyastella cyastella deleted the feature/v4_metadata branch October 22, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants