Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 task server setup #2371

Merged
merged 1 commit into from
Feb 21, 2020
Merged

v4 task server setup #2371

merged 1 commit into from
Feb 21, 2020

Conversation

cyastella
Copy link
Contributor

@cyastella cyastella commented Feb 19, 2020

Summary

Create v4 endpoint for the task/container with metadata/stats and set up task server.

Implementation details

Add v4 endpoint to fetch the info about the containerMetadata, taskMetadata, containerStats and taskStats with the specific paths. Test different network mode of the tasks like awsvpc, non-awsvpc mode and check the network info works as we expected.

Example awsvpc containerMetadata network info looks like:

"NetworkMode": "awsvpc",
"IPv4Addresses": ["172.31.47.69"],
"AttachmentIndex": 0,
"IPv4SubnetCIDRBlock": "172.31.32.0/20",
"MACAddress": "06:96:9a:ce:a6:ce",
"PrivateDNSName": "ip-172-31-47-69.us-west-2.compute.internal",
"SubnetGatewayIpv4Address": "172.31.32.1/20"

Example bridge containerMetadata network info looks like:

"NetworkMode": "bridge",
"IPv4Addresses": ["172.17.0.2"],
"AttachmentIndex": 0,
"IPv4SubnetCIDRBlock": "",
"MACAddress": "",
"SubnetGatewayIpv4Address": ""

Testing

Add unit tests for the task server set up to test v4 endpoint.

New tests cover the changes: yes

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cyastella cyastella changed the title Task server setup & unit tests v4 task server setup Feb 19, 2020
agent/handlers/task_server_setup.go Outdated Show resolved Hide resolved
@cyastella cyastella merged commit 5856981 into aws:feature/v4_metadata Feb 21, 2020
@cyastella cyastella added this to the 1.39.0 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants