v4 task and container stats handler #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumex93
reviewed
Feb 19, 2020
yumex93
approved these changes
Feb 19, 2020
mssrivas
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This add the initials outline for the task_stats_handler and container_stats_handler.
Implementation details
This PR doesn't create a v4 metadata endpoint yet, it creates the initial task_stats_handler and container_stats_handler. In each file we specify the path that users used to query task and container stats for v4 endpoint. We reuse V3EndpointID as an unique container identifier to build the v4 path.
Testing
New tests cover the changes:
I will add tests in task_server_setup in the next PR once finish implementing task_server setup part for v4 endpoint.
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.