Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to access and manage authState #665

Closed
wants to merge 11 commits into from
Closed

Document how to access and manage authState #665

wants to merge 11 commits into from

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Nov 10, 2021 •
edited
Loading

Issue #, if available: Depends on #637, closes #254, closes #664, related to #640.

Description of changes: Basically documenting how to do https://docs.amplify.aws/ui/auth/authenticator/q/framework/react/#recommended-usage on @next. In draft.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6357914

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wlee221 wlee221 temporarily deployed to ci November 10, 2021 01:42 Inactive
@wlee221 wlee221 temporarily deployed to ci November 10, 2021 01:42 Inactive
@wlee221 wlee221 temporarily deployed to ci November 10, 2021 01:42 Inactive
@wlee221 wlee221 temporarily deployed to ci November 11, 2021 21:34 Inactive
@wlee221 wlee221 temporarily deployed to ci November 11, 2021 21:34 Inactive
@wlee221 wlee221 temporarily deployed to ci November 11, 2021 21:34 Inactive
@wlee221 wlee221 temporarily deployed to ci November 11, 2021 22:05 Inactive
@wlee221 wlee221 temporarily deployed to ci November 11, 2021 22:05 Inactive
@wlee221 wlee221 temporarily deployed to ci November 11, 2021 22:05 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 04:32 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 04:32 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 04:32 Inactive
wlee221
wlee221 commented Nov 12, 2021
View reviewed changes
...r/src/lib/components/authenticator/components/amplify-sign-in/amplify-sign-in.component.html
data-amplify-fieldset
[disabled]="authenticator.isPending"
>
<div class="amplify-flex" style="flex-direction: column">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just matching other implementations

wlee221
wlee221 commented Nov 12, 2021
View reviewed changes
...lar/src/pages/ui/components/authenticator/use-authenticator/use-authenticator.component.html
@@ -0,0 +1,27 @@
<amplify-authenticator>
Copy link
Contributor Author

@wlee221 wlee221 Nov 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the Angular useAuthenticator example that demos "tabless" authenticator. Tabs are hidden through css here:

amplify-ui/examples/angular/src/styles.scss

Lines 15 to 17 in c32ef37

use-authenticator .amplify-tabs {
display: none;
}

And what they look like:

Screenshots

Screen Shot 2021-11-11 at 8 47 39 PM

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErikCH @ericclemmons Please add matching examples to this PR, thanks! 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this to a Headless UI milestone to do after GA, since this is an advanced use-case.

@wlee221 wlee221 temporarily deployed to ci November 12, 2021 04:50 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 04:50 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 04:50 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 05:46 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 05:46 Inactive
@wlee221 wlee221 temporarily deployed to ci November 12, 2021 05:46 Inactive
@ericclemmons ericclemmons added this to the Headless UI milestone Nov 12, 2021
@wlee221 wlee221 mentioned this pull request Nov 17, 2021
Merged
3 tasks
@wlee221 wlee221 closed this Jan 3, 2022
@wlee221
Copy link
Contributor Author

wlee221 commented Jan 4, 2022

Closing in favor of #1075

@wlee221 wlee221 deleted the docs/auth-state-and-routes branch December 22, 2022 23:31
thaddmt added a commit that referenced this pull request Apr 7, 2023
@thaddmt
fix: Revert liveness css (#665)
aa8f0cd 
* Revert "refactor(liveness): convert inline css to class (#664)"

This reverts commit 829c399.

* Revert "refactor(LIvenessCameraModule): change inline style to css class (#663)"

This reverts commit 886bc24.
thaddmt added a commit that referenced this pull request Apr 7, 2023
@thaddmt
Revert "fix: Revert liveness css (#665)" (#667)
38b16bd 
This reverts commit aa8f0cd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericclemmons ericclemmons ericclemmons left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
useAuthenticator Hook
Development

Successfully merging this pull request may close these issues.

docs: Document facades we provide Expose the Auth state to outside world
2 participants
@wlee221 @ericclemmons