Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document facades we provide #664

Closed
3 tasks done
wlee221 opened this issue Nov 10, 2021 · 2 comments · Fixed by #1075
Closed
3 tasks done

docs: Document facades we provide #664

wlee221 opened this issue Nov 10, 2021 · 2 comments · Fixed by #1075
Assignees
@wlee221
Labels
Documentation An issue or a feature-request for our Amplify UI Doc site or AWS Amplify docs feature-request Request a new feature
Milestone
useAuthenticator ...

Comments

@wlee221
Copy link
Contributor

wlee221 commented Nov 10, 2021 •
edited
Loading

Related: #254

We now provide public hooks/services for Authenticator: #532 (React), #588 (Vue), and #627 (Angular). We should document facades we provide.

We'll need to be careful to focus on actual use cases though, so that it's not just a giant table.

TODOs
@wlee221 wlee221 mentioned this issue Nov 10, 2021
Closed
@ericclemmons
Copy link
Contributor

https://codesandbox.io/s/change-your-layout-rh4z9?file=/src/App.js is a great example for React.

@Milan-Shah Milan-Shah added Documentation An issue or a feature-request for our Amplify UI Doc site or AWS Amplify docs ready-for-planning feature-request Request a new feature labels Nov 24, 2021
@wlee221
Copy link
Contributor Author

wlee221 commented Dec 15, 2021

It's been quite long since I last tackled this.

I think it'd be good to be a little verbose in documentation and provide tabs of facadades we provide:

tab 1 (context) - user, route, error, isPending, codeDeliveryDetails
tab 2 (transitions) - to* hooks and `signOut`
tab 3 (forms) - updateForm, submitForm

@wlee221 wlee221 mentioned this issue Jan 4, 2022
Merged
6 tasks
@wlee221 wlee221 mentioned this issue Jan 19, 2022
Merged
thaddmt pushed a commit that referenced this issue Apr 7, 2023
@0618 @zhamujun
refactor(liveness): convert inline css to class (#664)
829c399 
* refactor(liveness): convert cancel button inline css to class

* refactor(liveness): convert recording icon inline css to class

* refactor(liveness): convert description bullets inline css to class

Co-authored-by: MJ☔ <[email protected]>
thaddmt added a commit that referenced this issue Apr 7, 2023
@thaddmt
fix: Revert liveness css (#665)
aa8f0cd 
* Revert "refactor(liveness): convert inline css to class (#664)"

This reverts commit 829c399.

* Revert "refactor(LIvenessCameraModule): change inline style to css class (#663)"

This reverts commit 886bc24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlee221 wlee221

Labels
Documentation An issue or a feature-request for our Amplify UI Doc site or AWS Amplify docs feature-request Request a new feature
Projects
None yet
Milestone
useAuthenticator Hook
3 participants
@ericclemmons @Milan-Shah @wlee221