-
Notifications
You must be signed in to change notification settings - Fork 273
Feat/custom pk merge main #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HuiSF
merged 20 commits into
aws-amplify:feat/custom-pk
from
HuiSF:feat/custom-pk-merge-main
Mar 11, 2022
Merged
Feat/custom pk merge main #1432
HuiSF
merged 20 commits into
aws-amplify:feat/custom-pk
from
HuiSF:feat/custom-pk-merge-main
Mar 11, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Update issue template to GH form * Add N/A for placeholders * Minor updates * Minor fixes
… older flutter versions (aws-amplify#1385) * remove use of onInverseSurface * set min flutter version to 2.0.0 * update fallback color
* fix(core): Implement Result in AtomicResult * Fix AtomicResultTest
…m forms (aws-amplify#1377) * add initial category for ui customization * remove AuthState from the public API * remove auth bloc from public api * clean up public api, add docs * update for consistency, fix typos * change category name, fix typo * update install docs * update package description * update example project dir * uncomment example app imports * update template names * empty commit to trigger CI * update how runtime and custom fields are handled * move runtime fields to SignUpForm * fix signout button * Apply suggestions from code review Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * rename includeDefaultFields, update sort * Update packages/amplify_authenticator/lib/src/widgets/form.dart Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * make _includeDefaultFields private Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
* chore: authenticator v0.1.0 * Update packages/amplify_authenticator/pubspec.yaml Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
aws-amplify#1403) * add more detail to api docs for username * move docs to SignUpFormField
…-amplify#1409) * fix(datastore): delete default predicate causes deletion failure * fix save integration test
* Version bump * fix changelog 0.4.0 entry * Add PR #s
* add pana to ci * add missing colon * add install_melos step * move scope arg * move exec command to config * remove pana from melos * add remaining packages * address issue in authenticator package * disable failing packages * revert change to melos.yaml * add threshold * add quotes * escape quotes * escape << >> * escape <<< * update variable parsing * update parsing * remove trailing quote * add remaining packages * update variable name, add desc * adjust thresholds * decrease api threshold
dnys1
approved these changes
Mar 10, 2022
Contributor
dnys1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see why you need a review for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Merge latest
maininto the feature branch.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.