chore(amplify_auth_cognito) federated plugin #1349

haverchuck · 2022-02-09T00:07:39Z

Description of changes:
Creates _android and _ios federated plugins for cognito package.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

packages/amplify_auth_cognito_plugin/amplify_auth_cognito/pubspec.yaml

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_ios/example/analysis_options.yaml

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_ios/example/ios/Podfile

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_ios/lib/amplify_auth_cognito_ios.dart

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_android/README.md

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_ios/README.md

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_ios/example/lib/main.dart

melos.yaml

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_android/pubspec.yaml

Jordan-Nelson

Looks pretty good. Mostly nit comments. I think there are some files in the _android package that don't need to be there, and we should consider updating the version numbers in the change logs for the new packages

melos.yaml

Jordan-Nelson · 2022-03-01T19:08:32Z

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_android/example/pubspec.yaml

+    sdk: flutter
+  amplify_auth_cognito_android:
+    # When depending on this package from a real application you should use:
+    #   amplify_auth_cognito_ios: ^x.y.z


# amplify_auth_cognito_ios: ^x.y.z

Should that be amplify_auth_cognito_android? Or maybe we just remove this if this assuming it is auto generated. Not sure we need need this in the platform packages.

packages/amplify_auth_cognito_plugin/amplify_auth_cognito/example/tool/add_api_request.json

...h_cognito_plugin/amplify_auth_cognito_android/tool/adminCreateUserLambda/cloudformation.json

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_ios/CHANGELOG.md

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_android/CHANGELOG.md

dnys1 · 2022-03-01T21:39:13Z

Can we follow the Flutter team on layout?

plugin_name/
    plugin_name/
    plugin_name_platform_interface/
    plugin_name_ios/
    plugin_name_android/

So, maybe something like this:

auth/
    amplify_auth_cognito/
    amplify_auth_cognito_ios/
    amplify_auth_cognito_android/
    amplify_auth_plugin_interface/

dnys1 · 2022-03-01T21:44:27Z

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_android/example/README.md

@@ -0,0 +1,3 @@
+# amplify_auth_cognito_android_example


Do the platform packages need examples still if all the tests are in the main pkg's example?

We've put the platform-specific unit tests in the platform specific packages.

dnys1 · 2022-03-01T21:45:51Z

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_ios/example/ios/Podfile

  use_frameworks!
  use_modular_headers!

+  pod 'amplify_core', :path => './../../../../amplify_core/ios'


This shouldn't be needed and if it is, then we need to figure out why

[!] Unable to find a specification for `amplify_core` depended upon by `amplify_auth_cognito_ios`

Not totally sure why this happens (I would think the flutter_install_all_ios_pods command could handle this).

It's because amplify_auth_cognito_ios is missing a dependency on amplify_core. You'll also need to bump the min iOS version to 13.0 because melos adds a dependency on DataStore.

@dnys1 Made the change!

* chore: Update issue template to GH form (#1387) * chore: Update issue template to GH form * Add N/A for placeholders * Minor updates * Minor fixes * fix(amplify_authenticator): remove use of onInverseSurface to support older flutter versions (#1385) * remove use of onInverseSurface * set min flutter version to 2.0.0 * update fallback color * chore(amplify_authenticator): run unit tests for amplify_authenticator in CI (#1389) * fix(core): Implement Result in AtomicResult (#1393) * fix(core): Implement Result in AtomicResult * Fix AtomicResultTest * chore: Small QOS additions to bug report template (#1394) * fix(amplify_authenticator): allow multiple custom attributes in custom forms (#1377) * add initial category for ui customization * remove AuthState from the public API * remove auth bloc from public api * clean up public api, add docs * update for consistency, fix typos * change category name, fix typo * update install docs * update package description * update example project dir * uncomment example app imports * update template names * empty commit to trigger CI * update how runtime and custom fields are handled * move runtime fields to SignUpForm * fix signout button * Apply suggestions from code review Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * rename includeDefaultFields, update sort * Update packages/amplify_authenticator/lib/src/widgets/form.dart Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * make _includeDefaultFields private Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: authenticator v0.1.0 (#1402) * chore: authenticator v0.1.0 * Update packages/amplify_authenticator/pubspec.yaml Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: adds API for auth integ tests + minor fixes (#1302) * chore(amplify_authenticator): add more detail to api docs for username (#1403) * add more detail to api docs for username * move docs to SignUpFormField * fix overflow in custom loyout example (#1401) * chore: rename docs dir to doc (#1406) * chore(amplify_api): clean up some code to limit analysis infos (#1404) * fix(datastore): delete default predicate causes deletion failure (#1409) * fix(datastore): delete default predicate causes deletion failure * fix save integration test * Release 4.0.1 version bump (#1418) * Version bump * fix changelog 0.4.0 entry * Add PR #s * chore: add pub analysis to CI (#1408) * add pana to ci * add missing colon * add install_melos step * move scope arg * move exec command to config * remove pana from melos * add remaining packages * address issue in authenticator package * disable failing packages * revert change to melos.yaml * add threshold * add quotes * escape quotes * escape << >> * escape <<< * update variable parsing * update parsing * remove trailing quote * add remaining packages * update variable name, add desc * adjust thresholds * decrease api threshold * chore: remove obsolete integration test driver files (#1395) * fix(amplify_api): model helpers query predicates correctly translates… (#1417) * chore(amplify_auth_cognito) federated plugin (#1349) * chore(auth): fix pubspec urls (#1424) Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> Co-authored-by: Jordan Nelson <nejrd@amazon.com> Co-authored-by: Travis Sheppard <tshepp@amazon.com> Co-authored-by: Jordan Nelson <Jordan.Ryan.Nelson@gmail.com> Co-authored-by: Dustin Noyes <dustin.noyes.dev@gmail.com> Co-authored-by: Kyle <kylcheng@gmail.com>

haverchuck force-pushed the federate/cognito branch from dedc4a5 to df59dce Compare February 9, 2022 00:09

dnys1 reviewed Feb 9, 2022

View reviewed changes

cshfang reviewed Feb 9, 2022

View reviewed changes

Jordan-Nelson reviewed Feb 9, 2022

View reviewed changes

melos.yaml Outdated Show resolved Hide resolved

packages/amplify_auth_cognito_plugin/amplify_auth_cognito_android/pubspec.yaml Outdated Show resolved Hide resolved

haverchuck force-pushed the federate/cognito branch from d7de955 to 1fb55a8 Compare February 10, 2022 21:27

haverchuck changed the base branch from main to federate/cognito February 10, 2022 22:11

haverchuck changed the base branch from federate/cognito to main February 10, 2022 22:11

haverchuck force-pushed the federate/cognito branch 3 times, most recently from b852b06 to 0a83fdc Compare February 28, 2022 23:11

haverchuck requested review from Jordan-Nelson, cshfang and dnys1 March 1, 2022 17:25

Dustin Noyes added 17 commits March 1, 2022 09:31

added Android federated plugin

6a2fbbd

ios plugin

825106e

ios example app files

556e743

ios README and pubspec

558a805

mirgrated unit tests

8b2dd48

removes unneeded files and updates ci config

c805e4e

lint fix

b41a476

fixed types and amplify_flutter_example dependency

be01c76

handling plugin structure in unit test bash script

af32c8b

added android example app, updated unit test bash script

cf64d91

unit test fix

253d828

reverts bash change

f9d120a

chaged ios unit test directory

d9f9b16

updated android test resource path

64d1c65

fixed ios unit test name in podfile

5c68dd7

fixed ios tests

b57b8f6

updated analysis options

7139497

Dustin Noyes added 8 commits March 1, 2022 09:31

cleanup 2

2be67eb

removed jacoco file

9029c97

remeoved analysis options

d3ba568

remeoved analysis options

4a6c51d

cleanup 3

6dce4d9

downgrade compileSDK

3b4f39a

downgraded gradle version in cognito _android example

09ec7da

removed jacoco file from _android

4bffd17

haverchuck force-pushed the federate/cognito branch from 7eff492 to 4bffd17 Compare March 1, 2022 17:31

haverchuck marked this pull request as ready for review March 1, 2022 17:31

haverchuck requested a review from a team as a code owner March 1, 2022 17:31

Jordan-Nelson reviewed Mar 1, 2022

View reviewed changes

dnys1 reviewed Mar 1, 2022

View reviewed changes

Dustin Noyes added 3 commits March 1, 2022 14:39

removing dupe test files

21db825

restructured

aaf32f8

removed melos change

57ab87f

haverchuck changed the base branch from main to amplify-authenticator March 1, 2022 23:22

haverchuck changed the base branch from amplify-authenticator to main March 1, 2022 23:23

removed pubspec boilerplate

2bfd5f8

Jordan-Nelson approved these changes Mar 1, 2022

View reviewed changes

Dustin Noyes added 4 commits March 1, 2022 15:43

updated analytics example

6294ada

updated example app pubspecs

4de2763

removed unit test dependency

9f96025

replaced pod dependency

a258c96

haverchuck requested a review from dnys1 March 2, 2022 16:51

removed core pod from unit_test ios target

7be28e6

dnys1 approved these changes Mar 2, 2022

View reviewed changes

haverchuck merged commit a5399e4 into aws-amplify:main Mar 2, 2022

chore(amplify_auth_cognito) federated plugin #1349

chore(amplify_auth_cognito) federated plugin #1349

Uh oh!

Conversation

haverchuck commented Feb 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jordan-Nelson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jordan-Nelson Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

haverchuck Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dnys1 commented Mar 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnys1 Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

haverchuck Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

dnys1 Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

haverchuck Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnys1 Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

haverchuck Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dnys1 commented Mar 1, 2022 •

edited

Loading

haverchuck Mar 2, 2022 •

edited

Loading