chore: adds API for auth integ tests + minor fixes#1302
Merged
haverchuck merged 12 commits intoaws-amplify:mainfrom Feb 24, 2022
Merged
chore: adds API for auth integ tests + minor fixes#1302haverchuck merged 12 commits intoaws-amplify:mainfrom
haverchuck merged 12 commits intoaws-amplify:mainfrom
Conversation
fjnoyp
approved these changes
Jan 25, 2022
Contributor
|
Question: As auth integ tests now require API, would it be possible to update the resource provisioning to reflect how to create that part of backend? Could either update existing provision script at https://github.com/aws-amplify/amplify-flutter/blob/main/packages/amplify_auth_cognito/example/tool/provision_integration_test_resources.sh#L24, see api example https://github.com/aws-amplify/amplify-flutter/blob/main/packages/amplify_api/example/tool/provision_integration_test_resources.sh#L24, or checkin the the partial amplify dir to this test so it can use pull. Or, could update README to explain how to provision and I can update the provisioning some other time as I've been meaning to checkin the amplify dir for this test. |
haverchuck
force-pushed
the
auth-integ-tests
branch
from
45880dd to
de732e4
Compare
packages/amplify_auth_cognito/example/tool/provision_integration_test_resources.sh
Outdated
Show resolved
Hide resolved
added 7 commits
February 23, 2022 06:56
haverchuck
force-pushed
the
auth-integ-tests
branch
from
c6a2418 to
e9299ae
Compare
ragingsquirrel3
suggested changes
Feb 24, 2022
Contributor
ragingsquirrel3
left a comment
ragingsquirrel3
left a comment
There was a problem hiding this comment.
This is looking pretty good! I left some comments about how to improve the provision script to run with different AWS profiles as I think this will be needed given amplify headless commands and aws CLI commands can resolve to different accounts in some circumstances.
I can discuss it more offline as I debugged it locally a bit.
packages/amplify_auth_cognito/example/tool/provision_integration_test_resources.sh
Show resolved
Hide resolved
packages/amplify_auth_cognito/example/tool/provision_integration_test_resources.sh
Show resolved
Hide resolved
packages/amplify_auth_cognito/example/tool/provision_integration_test_resources.sh
Outdated
Show resolved
Hide resolved
Contributor
|
nit request: Would it be possible to update the provision instructions in contributing.md as I think there are some instructions for manually editing the auth backend that are no longer necessary with this change? |
packages/amplify_auth_cognito/example/tool/provision_integration_test_resources.sh
Outdated
Show resolved
Hide resolved
packages/amplify_auth_cognito/example/tool/provision_integration_test_resources.sh
Outdated
Show resolved
Hide resolved
ragingsquirrel3
approved these changes
Feb 24, 2022
HuiSF
added a commit
that referenced
this pull request
Mar 11, 2022
* chore: Update issue template to GH form (#1387) * chore: Update issue template to GH form * Add N/A for placeholders * Minor updates * Minor fixes * fix(amplify_authenticator): remove use of onInverseSurface to support older flutter versions (#1385) * remove use of onInverseSurface * set min flutter version to 2.0.0 * update fallback color * chore(amplify_authenticator): run unit tests for amplify_authenticator in CI (#1389) * fix(core): Implement Result in AtomicResult (#1393) * fix(core): Implement Result in AtomicResult * Fix AtomicResultTest * chore: Small QOS additions to bug report template (#1394) * fix(amplify_authenticator): allow multiple custom attributes in custom forms (#1377) * add initial category for ui customization * remove AuthState from the public API * remove auth bloc from public api * clean up public api, add docs * update for consistency, fix typos * change category name, fix typo * update install docs * update package description * update example project dir * uncomment example app imports * update template names * empty commit to trigger CI * update how runtime and custom fields are handled * move runtime fields to SignUpForm * fix signout button * Apply suggestions from code review Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * rename includeDefaultFields, update sort * Update packages/amplify_authenticator/lib/src/widgets/form.dart Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * make _includeDefaultFields private Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: authenticator v0.1.0 (#1402) * chore: authenticator v0.1.0 * Update packages/amplify_authenticator/pubspec.yaml Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: adds API for auth integ tests + minor fixes (#1302) * chore(amplify_authenticator): add more detail to api docs for username (#1403) * add more detail to api docs for username * move docs to SignUpFormField * fix overflow in custom loyout example (#1401) * chore: rename docs dir to doc (#1406) * chore(amplify_api): clean up some code to limit analysis infos (#1404) * fix(datastore): delete default predicate causes deletion failure (#1409) * fix(datastore): delete default predicate causes deletion failure * fix save integration test * Release 4.0.1 version bump (#1418) * Version bump * fix changelog 0.4.0 entry * Add PR #s * chore: add pub analysis to CI (#1408) * add pana to ci * add missing colon * add install_melos step * move scope arg * move exec command to config * remove pana from melos * add remaining packages * address issue in authenticator package * disable failing packages * revert change to melos.yaml * add threshold * add quotes * escape quotes * escape << >> * escape <<< * update variable parsing * update parsing * remove trailing quote * add remaining packages * update variable name, add desc * adjust thresholds * decrease api threshold * chore: remove obsolete integration test driver files (#1395) * fix(amplify_api): model helpers query predicates correctly translates… (#1417) * chore(amplify_auth_cognito) federated plugin (#1349) * chore(auth): fix pubspec urls (#1424) Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> Co-authored-by: Jordan Nelson <nejrd@amazon.com> Co-authored-by: Travis Sheppard <tshepp@amazon.com> Co-authored-by: Jordan Nelson <Jordan.Ryan.Nelson@gmail.com> Co-authored-by: Dustin Noyes <dustin.noyes.dev@gmail.com> Co-authored-by: Kyle <kylcheng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds adminCreateUser to auth integ test and a few minor test fixes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.