Skip to content

Conversation

@palpatim
Copy link
Member

This reverts commit 0e003d2.

Description of changes

The previous commit (#2971, which re-enables #2961) introduces a behavior that automatically annotates a custom type with @aws_iam if enableIamAuthorizationMode is true.

This breaks customer schemas who rely on AppSync's default authorization mode to authorize custom types. E.g., the following scenario:

  • Default authorization mode: Cognito User Pools
  • Enable IAM Authorization: true
  • Schema
    type Foo {
      bar: String
      baz: Int
    }
    
    type Query {
      getFoo: Foo
        @auth(rules: [{ allow: private }])
        @function(name: "foofunction")
    }

We must not re-merge this change until we have better test coverage of all the use cases and edge cases that this could impact.

Issue #, if available

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@palpatim palpatim merged commit 8da7802 into main Oct 22, 2024
7 checks passed
@palpatim palpatim deleted the palpatim.revert-iam-auth branch October 22, 2024 21:31
tejas2008 pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants